Disable TC when no Docker around #9989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As many of IQSS and external devs might not have Docker available, let's deactivate any Testcontainers tests in these cases.
poikilotherm
added
Feature: Developer Guide
Component: Containers
pdurbin
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Works great. In the output you still see SEVERE: Could not find a valid Docker environment but the mvn install works without Docker running! Thanks, @poikilotherm! Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Disabling Testcontainers tests when no Docker is available unblocks devs that don't run these tests locally.
Which issue(s) this PR closes:
Closes #9974
Special notes for your reviewer:
None
Suggestions on how to test this:
Run
mvn installon a machine without Docker, see it not fail.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope
Is there a release notes update needed for this change?:
Nope
Additional documentation:
None