Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some fields, the
isajson
schema is too strict to pass validation for the example files provided here: https://github.com/ISA-tools/ISAdatasets/tree/master/jsonThis is because of two types of fields, namely the
@id
fields and thedate
fields.@id
fields are defined in the schemas to only validate against strings of formaturi
, which expects full uris likehttp://example.org/wiki/Main_Page
. In contrast to this, ids like"#sample/sample-N-0.2-aliquot2"
are used, which seems sensible to do but fails the validation. Using the format specificationuri-reference
instead ofuri
could soften this up, but requiresjson schema draft 06
.@date
fields are defined in the schemas to only validate against strings of formatdate-time
, which expects full date and time information like2020-05-04T02:15:00.0Z
but fails when just specifying the date. I propose to use anany-of
betweendate-time
anddate
, which requiresjson schema draft 07
.In this PR are my requested changes, upping the json schema draft version and using the aforementioned string format specification changes.
The example files also contain other errors causing the validation to fail, but these are actual format errors like empty strings when a URI should be given. I will open up an issue there