Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket6777 #163

Merged
merged 6 commits into from
Aug 2, 2023
Merged

Ticket6777 #163

merged 6 commits into from
Aug 2, 2023

Conversation

boeuf-codes
Copy link
Contributor

@boeuf-codes boeuf-codes commented Apr 17, 2023 •
edited
Loading

Ticket #6777

  • Added relevant needle valve records as properties
  • Added getters/setters where appropriate

@boeuf-codes boeuf-codes mentioned this pull request Apr 17, 2023
Closed
5 tasks
Tom-Willemsen
Tom-Willemsen reviewed Apr 24, 2023
View reviewed changes
lewis_emulators/eurotherm/interfaces/modbus_interface.py Outdated
self.write_commands[mem_address](value)
except:
import traceback
traceback.print_exc()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the exception should be reraised after logging, or this should explicitly return nothing

esmith1729
esmith1729 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@esmith1729 esmith1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The device emulator works well, and the new property name changes have been integrated into other parts of the code (IOCTestFramework specifically)

@esmith1729 esmith1729 merged commit 3ae45b2 into master Aug 2, 2023
@esmith1729 esmith1729 deleted the Ticket6777 branch August 3, 2023 11:04
@esmith1729 esmith1729 restored the Ticket6777 branch August 17, 2023 08:36
@esmith1729 esmith1729 deleted the Ticket6777 branch August 17, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tom-Willemsen Tom-Willemsen Tom-Willemsen left review comments

@esmith1729 esmith1729 esmith1729 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boeuf-codes @Tom-Willemsen @esmith1729 @FreddieAkeroyd