Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and generalise TPG300 emulator #169

Merged
merged 12 commits into from
Aug 22, 2023
Merged

Refactor and generalise TPG300 emulator #169

merged 12 commits into from
Aug 22, 2023

Conversation

boeuf-codes
Copy link
Contributor

Description of work

  • Update/fix docstrings
  • Rename tpg300 emulator to tpgx00 emulator

device.py:

  • Add properties to support new commands
  • Refactor to store enum members rather than explicit values (in emulator properties)

stream_interface.py:

  • Add protocols for TPG 300 and 500 models
  • Refactor to handle enum members from device.py
  • Add methods to protocols to translate enum members to values

Ticket

#7458

@zsoltkebel
Copy link
Contributor

Because the commands to the device don't all have the same terminator (namely the command doesn't have any, all the others have CR LF) the device seems to be waiting for the readtimeout every time on . These delays seem to have caused unreliability in testing so I reduced the readtimeout to 1 millisec. This should be fine as the commands are sent to the device as one block there should not be delay between parts of the same command.

@esmith1729 esmith1729 merged commit a2d33c7 into master Aug 22, 2023
@esmith1729 esmith1729 deleted the Ticket7458 branch August 22, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants