Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use venvs #420

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use venvs #420

wants to merge 4 commits into from

Conversation

rerpha
Copy link
Contributor

@rerpha rerpha commented Feb 27, 2025 •
edited
Loading

Description of work

(review #414 first)

To test

Which ticket does this PR fix?

Acceptance criteria

List the acceptance criteria for the PR

Code Review

  • Is the code of an acceptable quality?
  • Has the author taken into account the multi-threaded nature of the code?
  • Have the changes been recorded appropriately in a PR for release notes?
  • Has the manual system tests spreadsheet been updated?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.

Final steps

  • Reviewer has updated the submodule in the main EPICS repo? See Reviewing work for the subModules of EPICS in the Git workflow page for details.
  • Reviewer has merged the associated PR for the release notes

@rerpha rerpha mentioned this pull request Feb 27, 2025
Open
@rerpha rerpha marked this pull request as ready for review March 11, 2025 11:49
@rerpha
Copy link
Contributor Author

rerpha commented Mar 11, 2025

whoops - marked this as ready but actually we decided we might do venvs a different way - hold off merging for now pls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rerpha