Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: AIRAM generic resource and underlying reason #9

Merged

Conversation

mrnicegyu11
Copy link
Member

@mrnicegyu11 mrnicegyu11 commented Jan 23, 2025

This PR

  • changes the requirements from "1" unit of AIRAM to "1" unit of VRAM
  • By setting the TF_FORCE_GPU_ALLOW_GROWTH=true env-var in the dockerfile of Tensorflow stopping tensorflow from greedily allocating all GPU VRAM
  • Bumps the minor version from 2.0.2 to 2.1.0

@GitHK can you advice if there is CI/CD or how this should be published to all ospars? thx!

CC @YuryHrytsuk When this gets in there will be no more AIRAM service.

@mrnicegyu11 mrnicegyu11 added the enhancement New feature or request label Jan 23, 2025
@mrnicegyu11 mrnicegyu11 requested a review from mguidon January 23, 2025 14:50
@mrnicegyu11 mrnicegyu11 self-assigned this Jan 23, 2025
@mrnicegyu11 mrnicegyu11 marked this pull request as ready for review January 23, 2025 14:57
Copy link
Collaborator

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sufficient for the internal CI to trigger a build and push the 2.1.0 version inside the z43 docker repo.
Then in the images sync tool just add this version to the deployment you intend to use it and it will eventually be build.

Make sure that after this PR is merged the CI is green in the master branch of this repo. Only then then builder will pickup this version and automatically built it for you

@GitHK
Copy link
Collaborator

GitHK commented Jan 23, 2025

@mrnicegyu11 I wonder why you don't have a CI run for this

Copy link
Collaborator

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trigger CI

Copy link
Collaborator

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and merge it. The CI should build it in master inside this REPO

@GitHK GitHK closed this Jan 24, 2025
@GitHK GitHK reopened this Jan 24, 2025
@GitHK
Copy link
Collaborator

GitHK commented Jan 24, 2025

when I recreated the PR it did not trigger the CI. I don't know why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants