Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce rolling docker config / secret update concept 🎉 🚀 #952

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Introduce rolling docker config / secret update concept 🎉 🚀 #952

merged 2 commits into from
Jan 30, 2025

Conversation

YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Jan 29, 2025 •
edited
Loading

What do these changes do?

  • Add workflow to enable rolling (on-the-fly) docker config / secret updates.
  • Provide an example on how to use this workflow via appmotion gateway api env config

Details

  • In order to guarantee rolling updates, add a hash suffix to the config name.
  • This can also apply to external config / secrets via the same name-change mechanism.
  • With this mechanism in place, it is important to clean up old docker config versions. For this reason, special makefile targets were introduced
  • Find many useful articles, docs and resources in the description of Add automated sustainable workflow to update docker configs / secrets #949

Related issue/s

Related PR/s

Checklist

  • I tested and it works

@YuryHrytsuk YuryHrytsuk changed the title fixes Introduce rolling docker configs / secrets updates Jan 29, 2025
@YuryHrytsuk YuryHrytsuk requested a review from sanderegg January 29, 2025 13:48
@YuryHrytsuk YuryHrytsuk self-assigned this Jan 29, 2025
@YuryHrytsuk YuryHrytsuk added the t:enhancement New feature or request label Jan 29, 2025
@YuryHrytsuk YuryHrytsuk added this to the Singularity milestone Jan 29, 2025
@YuryHrytsuk YuryHrytsuk marked this pull request as ready for review January 29, 2025 13:49
@YuryHrytsuk YuryHrytsuk changed the title Introduce rolling docker configs / secrets updates Introduce rolling docker configs / secrets updates 🎉 🚀 Jan 29, 2025
@YuryHrytsuk YuryHrytsuk changed the title Introduce rolling docker configs / secrets updates 🎉 🚀 Introduce rolling docker configs / secrets updates concept 🎉 🚀 Jan 29, 2025
@YuryHrytsuk YuryHrytsuk changed the title Introduce rolling docker configs / secrets updates concept 🎉 🚀 Introduce rolling docker config / secret update concept 🎉 🚀 Jan 29, 2025
mrnicegyu11
mrnicegyu11 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sieht gut aus, very surgical but this could work I see no issues with the code design. Good luck!

scripts/common.Makefile Show resolved Hide resolved
sanderegg
sanderegg approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you will update them on every release?

@YuryHrytsuk
Copy link
Collaborator Author

so you will update them on every release?

only on file content change

@YuryHrytsuk YuryHrytsuk merged commit dc8e56e into ITISFoundation:main Jan 30, 2025
3 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-ops-environments that referenced this pull request Feb 3, 2025
@YuryHrytsuk @mrnicegyu11
Introduce rolling docker config / secret update concept 🎉 🚀 (ITISFoun…
8728f6c 
…dation#952)

* fixes

* update comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

Assignees

@YuryHrytsuk YuryHrytsuk

Labels
t:enhancement New feature or request
Projects
None yet
Milestone
Singularity
Development

Successfully merging this pull request may close these issues.

Add automated sustainable workflow to update docker configs / secrets
3 participants
@YuryHrytsuk @mrnicegyu11 @sanderegg