Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First draft of FusionTensor #5
base: main
Are you sure you want to change the base?
First draft of FusionTensor #5
Changes from 28 commits
3dd5ff2
11a5d88
afed27a
5ed5b8e
d66540c
a9dc29f
d7edb71
4a8f9ba
e75d783
705b7aa
deaf6b1
8ab786e
563bae1
b35757b
0299e4b
4647030
e53bffd
2794d60
a23939c
f9b0daa
d816193
899bed8
3ef076d
cdd3a2f
9ed1f1a
4f746b8
6528b63
cc9c7dc
067403b
ee06e3f
837e151
423b275
7decaa4
3eb6a8e
62e09ef
4057fe8
f663d05
03080e3
9247074
22c5e51
ab9a76a
aaac06a
591bcbc
192fe47
5f2452d
4e94367
20a3119
260760f
7342477
cb15d63
b751f9e
1dc72ae
d3b624e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use
symbol_1j
, it might be more internally consistent to then also use thesymbol_3j
andsymbol_6j
notations instead ofclebsch_gordan_tensor
? In general, clebsch gordan seems to be very often related specifically to SU(N) anyways.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have a strong opinion here. We can have both
symbol_1/3/6j
andflipper
,clebsch_gordan
andf_symbol
interface, with one implementation and one converter.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this is adapted from TensorKit anyways, how would you feel about:
I don't think there is a lot of value in having the implementation copied here, it's definitely more maintenance and error-prone, so it would be cool if we could immediately share this.
(This is a registered light-weight package that only contains the symmetry data, so the dependency is quite light, and this automatically inherits many of the symmetries)
https://github.com/QuantumKitHub/TensorKitSectors.jl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds reasonable to me.