-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start reexporting ITensorTDVP and ITensors.ITensorMPS #1
Conversation
@emstoudenmire once this is merged I think we can go ahead and register v0.1 of this package and start advertising it, i.e.:
|
I'll go ahead and merge this. Since our official recommendation at first will just be to change |
Looks good. I commented on the other PR. I couldn't see any issues with how you split the exports. The only non-obvious thing to me was the
|
Thanks for looking it over, it is helpful to get a sanity check on this. Yes that's a good summary. For now the official recommendation will be to do As you say, one option could be |
See also ITensor/ITensors.jl#1410, there you can see a list of exports that will be left in
ITensors.jl
if these are removed from there and moved here.@emstoudenmire curious what you think about this list of exports.
My thinking is that we should try to move any exports that are primarily used for MPS code here, so that we can then remove them as exports from ITensors.jl (which has way too many exports right now).
The idea is that if users type
using ITensors, ITensorMPS
we make sure there code still "just works", so a way of doing that would be to divide the current exports of ITensors into ones we plan to continue exporting from ITensors and ones we plan to only export from ITensorMPS (there could be an overlap but I don't see a need for that).