Skip to content

Refactor interfaces built around alternating update #245

Refactor interfaces built around alternating update

Refactor interfaces built around alternating update #245

Triggered via pull request January 17, 2024 23:19
Status Failure
Total duration 1m 11s
Artifacts

format_suggestions.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 10 warnings
format
reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
format
Process completed with exit code 1.
format: src/treetensornetworks/solvers/update_step.jl#L18
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/treetensornetworks/solvers/update_step.jl:18:- cutoff, maxdim, mindim, outputlevel::Int=0, psi, region_updates, spec, which_region_update, which_sweep,kwargs... src/treetensornetworks/solvers/update_step.jl:18:+ cutoff, src/treetensornetworks/solvers/update_step.jl:19:+ maxdim, src/treetensornetworks/solvers/update_step.jl:20:+ mindim, src/treetensornetworks/solvers/update_step.jl:21:+ outputlevel::Int=0, src/treetensornetworks/solvers/update_step.jl:22:+ psi, src/treetensornetworks/solvers/update_step.jl:23:+ region_updates, src/treetensornetworks/solvers/update_step.jl:24:+ spec, src/treetensornetworks/solvers/update_step.jl:25:+ which_region_update, src/treetensornetworks/solvers/update_step.jl:26:+ which_sweep, src/treetensornetworks/solvers/update_step.jl:27:+ kwargs...,
format: src/treetensornetworks/solvers/update_step.jl#L21
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/treetensornetworks/solvers/update_step.jl:21:- region=first(region_updates[which_region_update]) src/treetensornetworks/solvers/update_step.jl:30:+ region = first(region_updates[which_region_update])
format: src/treetensornetworks/solvers/update_step.jl#L63
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/treetensornetworks/solvers/update_step.jl:63:- src/treetensornetworks/solvers/update_step.jl:72:+
format: src/treetensornetworks/solvers/update_step.jl#L66
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/treetensornetworks/solvers/update_step.jl:66:- (region, region_kwargs)=region_updates[which_region_update] src/treetensornetworks/solvers/update_step.jl:67:- region_kwargs=merge(region_kwargs, sweep_params) #in this case sweep params has precedence over step_kwargs --- correct behaviour? src/treetensornetworks/solvers/update_step.jl:75:+ (region, region_kwargs) = region_updates[which_region_update] src/treetensornetworks/solvers/update_step.jl:76:+ region_kwargs = merge(region_kwargs, sweep_params) #in this case sweep params has precedence over step_kwargs --- correct behaviour?
format: src/treetensornetworks/solvers/update_step.jl#L83
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/treetensornetworks/solvers/update_step.jl:83:- select!(region_observer!, Observers.DataFrames.Not("region_printer")) # remove step_printer #todo fix this src/treetensornetworks/solvers/update_step.jl:92:+ select!(region_observer!, Observers.DataFrames.Not("region_printer")) # remove step_printer #todo fix this
format: src/treetensornetworks/solvers/update_step.jl#L177
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/treetensornetworks/solvers/update_step.jl:177:- updater_kwargs src/treetensornetworks/solvers/update_step.jl:186:+ updater_kwargs,
format: src/treetensornetworks/solvers/update_step.jl#L179
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/treetensornetworks/solvers/update_step.jl:179:- region=first(region_updates[which_region_update]) src/treetensornetworks/solvers/update_step.jl:188:+ region = first(region_updates[which_region_update])
format: src/treetensornetworks/solvers/update_step.jl#L186
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/treetensornetworks/solvers/update_step.jl:186:- PH_ref! = Ref(PH) src/treetensornetworks/solvers/update_step.jl:195:+ PH_ref! = Ref(PH)
format: src/treetensornetworks/solvers/update_step.jl#L196
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/treetensornetworks/solvers/update_step.jl:196:- updater_kwargs src/treetensornetworks/solvers/update_step.jl:205:+ updater_kwargs,
format: src/treetensornetworks/solvers/update_step.jl#L214
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/treetensornetworks/solvers/update_step.jl:214:- psi, phi, region; eigen_perturbation=drho, ortho, normalize, src/treetensornetworks/solvers/update_step.jl:223:+ psi, src/treetensornetworks/solvers/update_step.jl:224:+ phi, src/treetensornetworks/solvers/update_step.jl:225:+ region; src/treetensornetworks/solvers/update_step.jl:226:+ eigen_perturbation=drho, src/treetensornetworks/solvers/update_step.jl:227:+ ortho, src/treetensornetworks/solvers/update_step.jl:228:+ normalize,