-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fermionic OpSum
to TTN
constructor
#122
Conversation
…einds for TTN constructor.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
+ Coverage 72.55% 72.90% +0.35%
==========================================
Files 71 71
Lines 4055 4097 +42
==========================================
+ Hits 2942 2987 +45
+ Misses 1113 1110 -3 ☔ View full report in Codecov by Sentry. |
…d sites that have QN-sectors of size larger than one --- may or may not be specific to fermionic sites.
…hubbard Hamiltonian setup.
…aring blocks of fermionic tensors.
@mtfishman @emstoudenmire |
Nice! So did you find & fix that other bug that was showing up for electrons but was related to QNs? |
That one turned out to be a typo in the Hubbard model OpSum that made it
have nonzero flux.
…On Fri, Jan 12, 2024, 7:06 PM Miles ***@***.***> wrote:
Nice! So did you find & fix that other bug that was showing up for
electrons but was related to QNs?
—
Reply to this email directly, view it on GitHub
<#122 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGL4SEJ3LNVSZBG6GVKEVQTYOHFW3AVCNFSM6AAAAABBXQN3V6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQGE3DGNJQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I'm excited to hear it's already working. Is it passing tests on multiple fermionic cases? If so this is a big development. |
It's working for spinless fermions and the Hubbard model (including next-nearest neighbors in both cases). |
Those are some pretty strenuous tests. Great. We can discuss the failing ITensor comparison test, since maybe that's more of a low-level bug with ITensors.jl ? |
OpSum
to TTN
constructor
Looks good, thanks a lot @b-kloss. This is a big step forward for ITensor! I think it is ready to merge once the new round of comments are addressed. |
Co-authored-by: Matt Fishman <[email protected]>
…on is used and add comment.
Looks good, thanks again. I'll merge once tests pass. |
This PR generalizes the construction of
TTN
s fromOpSum
s to systems with fermionic degrees of freedom whenITensors.using_auto_fermion()==true
.The implementation closely follows the logic in the
OpSum
toMPO
constructor inITensors.jl
(in fact replicates quite a bit of code) and does not expose theauto_fermion
logic.The functionality passes tests (
test/test_opsum_to_ttno.jl
) for fermions and electrons.Tests added:
test_opsum_ttn.jl
: tests for non-fermionicQN
inds
on comb graph, and comb graph with a single internal vertex. These tests contract the HamiltonianTTNO
and compare with one generated byITensors.MPO
.test_opsum_ttn.jl
: tests for fermionicQN
inds
on comb graph forNNN
tight-binding model on comb graph. Since comparison\approxeq
between fermionic ITensors is broken, the Hamiltonian is cast into a dense matrix for bothTTN
andMPO
format (using Combiners) and compared.test_treetensornetworks/test_solvers/test_dmrg.jl
: tests added forNNN
heisenberg
andhubbard
model on comb graph, comparison of ground state energies with result fromITensors.dmrg
. Tests for single-site DMRG withQNs
have been removed due to missingrandom_ttn
and lack ofsubspace_expansion
.To Do:
ttn_svd
.svd_ttn
.