-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize ProjTTNSum
, replace ProjTTNApply
with ProjOuterProdTTN
#132
Conversation
…N instead of ProjTTN.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 72.87% 73.24% +0.36%
==========================================
Files 68 68
Lines 3982 4033 +51
==========================================
+ Hits 2902 2954 +52
+ Misses 1080 1079 -1 ☔ View full report in Codecov by Sentry. |
@b-kloss this looks like a promising approach to supporting more general sums of projected operators. Definitely preferable to defining a new |
If tests pass this is ready for review from my side. |
Co-authored-by: Matt Fishman <[email protected]>
Co-authored-by: Matt Fishman <[email protected]>
…neralize-projttnsum
ProjTTNSum
ProjTTNSum
, replace ProjTTNApply
with ProjOuterProdTTN
Looks good, thanks! Over all a nice improvement which extends the functionality a lot (but also cleans up the code). |
This PR intends to generalize the design of
ProjTTNSum
to beVectors
of an arbitrary concrete subtype of AbstractProjTTN.Changes:
ProjTTNSum
subtype ofAbstractProjTTN
and and represent a sum arbitraryAbstractProjTTN
position
, in line with recent changes toposition
for AbstractProjTTN.ProjTTNApply
toProjOuterProdTTN
and redefine functionality to be in line with that ofProjTTN
for an operatorO
of the formO=A|v><v|A^dagger
. The prior functionality is accessible viacontract_ket
, which is used e.g. incontract_updater
, the backend for variational compression of|x> = \sum_i A_i |b_i>
.ToDo:
ProjTTNApply