Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BP Efficiency Improvement #194

Merged
merged 8 commits into from
Sep 3, 2024
Merged

BP Efficiency Improvement #194

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
677d49b
Testing in-place vs out-of-place versions
JoeyT1994 Jul 10, 2024
bdf2b4d
avoid use of get
JoeyT1994 Jul 11, 2024
92f0f2c
Merge remote-tracking branch 'upstream/main' into BP_inplace
JoeyT1994 Jul 11, 2024
fc96369
Restore file
JoeyT1994 Jul 11, 2024
6d0bb52
Restore file
JoeyT1994 Jul 11, 2024
b5699e5
Restore file
JoeyT1994 Jul 11, 2024
e1e13ba
Restore file
JoeyT1994 Jul 11, 2024
22515ea
Use `get` again but with first argument
JoeyT1994 Jul 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/caches/beliefpropagationcache.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ end

function message(bp_cache::BeliefPropagationCache, edge::PartitionEdge)
mts = messages(bp_cache)
return get(mts, edge, default_message(bp_cache, edge))
return get(() -> default_message(bp_cache, edge), mts, edge)
end
function messages(bp_cache::BeliefPropagationCache, edges; kwargs...)
return map(edge -> message(bp_cache, edge; kwargs...), edges)
Expand Down Expand Up @@ -152,15 +152,16 @@ end
function environment(bp_cache::BeliefPropagationCache, verts::Vector)
partition_verts = partitionvertices(bp_cache, verts)
messages = environment(bp_cache, partition_verts)
central_tensors = ITensor[
tensornetwork(bp_cache)[v] for v in setdiff(vertices(bp_cache, partition_verts), verts)
]
central_tensors = factors(bp_cache, setdiff(vertices(bp_cache, partition_verts), verts))
return vcat(messages, central_tensors)
end

function factors(bp_cache::BeliefPropagationCache, verts::Vector)
return ITensor[tensornetwork(bp_cache)[v] for v in verts]
end

function factor(bp_cache::BeliefPropagationCache, vertex::PartitionVertex)
ptn = partitioned_tensornetwork(bp_cache)
return collect(eachtensor(subgraph(ptn, vertex)))
return factors(bp_cache, vertices(bp_cache, vertex))
end

"""
Expand Down
Loading