Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template to use organization actions #11

Merged
merged 10 commits into from
Dec 2, 2024
Merged

Conversation

lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Nov 22, 2024

No description provided.

@lkdvos
Copy link
Collaborator Author

lkdvos commented Dec 2, 2024

@mtfishman , I think this should be more or less ready, I'll add the updated installation instructions in a separate PR (or do you prefer that here as well)?

Do you know of a reasonable way to tests these actions, apart from just applying this template to one of the packages and checking if everything works? It's a bit annoying for me to do this, since on forked repositories the privileges are actually different from the base ones, so that wouldn't fully reproduce the environment.

@mtfishman
Copy link
Member

@mtfishman , I think this should be more or less ready, I'll add the updated installation instructions in a separate PR (or do you prefer that here as well)?

A separate PR for that would be better.

Do you know of a reasonable way to tests these actions, apart from just applying this template to one of the packages and checking if everything works? It's a bit annoying for me to do this, since on forked repositories the privileges are actually different from the base ones, so that wouldn't fully reproduce the environment.

Two ways I came up with were:

  1. use the new skeletons to regenerate parts of ITensorPkgSkeleton.jl itself, and
  2. generate a package in a temporary repository and check properties of what got generated: https://github.com/ITensor/ITensorPkgSkeleton.jl/blob/main/test/test_basics.jl, for example check that certain files were generated, lines in certain files were generated, etc.

@lkdvos
Copy link
Collaborator Author

lkdvos commented Dec 2, 2024

Right, but there's no real way to test the github workflows like that right?

@mtfishman
Copy link
Member

Right, but there's no real way to test the github workflows like that right?

I guess it checks them implicitly, i.e. you can check parts got generated correctly, and also you can see if the ITensorPkgSkeleton.jl CI runs properly after they are generated from the skeleton.

@lkdvos
Copy link
Collaborator Author

lkdvos commented Dec 2, 2024

This should now have been done, so this PR is ready from my side.
Closes #11

@lkdvos lkdvos requested a review from mtfishman December 2, 2024 23:03
@mtfishman
Copy link
Member

Looks good, thanks!

@mtfishman mtfishman merged commit c88a0db into ITensor:main Dec 2, 2024
8 checks passed
@lkdvos lkdvos deleted the actions branch December 2, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants