Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fermion cases in blocksparse SVD #1212

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Fix fermion cases in blocksparse SVD #1212

merged 2 commits into from
Oct 17, 2023

Conversation

emstoudenmire
Copy link
Collaborator

Some previously working cases of the SVD for auto fermion stopped working due to changes in NDTensors/src/blocksparse/linearalgebra.jl. This PR changes those lines of code back to a correctly working version and restores the corresponding tests which were marked as broken.

With this PR, all four "matrix" cases of the SVD should again be working.

The other cases which are still marked as broken are also likely conceptually correct as long as one correctly conjugates certain mixed arrows with a parity tensor before determining whether U or V are unitary. So in a sense it is those last two tests which are broken, not the ITensor code. (This PR does not address those tests; just mentioning it for context.)

@mtfishman
Copy link
Member

Thanks for catching that, that was my mistake.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e571300) 85.39% compared to head (1ccc3a8) 67.34%.
Report is 2 commits behind head on main.

❗ Current head 1ccc3a8 differs from pull request most recent head 350370b. Consider uploading reports for the commit 350370b to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1212       +/-   ##
===========================================
- Coverage   85.39%   67.34%   -18.05%     
===========================================
  Files          89       88        -1     
  Lines        8426     8388       -38     
===========================================
- Hits         7195     5649     -1546     
- Misses       1231     2739     +1508     

see 36 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman merged commit b5d963e into main Oct 17, 2023
7 checks passed
@mtfishman mtfishman deleted the fermion_refix_svd branch October 17, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants