feat(commands) #26: Implement Commands module

[atschabu]

Implementor is responsible for async handling of calling callback via the client

Example implementation of postStartSession

    override suspend fun postStartSession(
        partnerUrl: String,
        startSession: StartSession,
    ): OcpiResponseBody<CommandResponse> {
        validate {
            validateLength("response_url", startSession.responseUrl, 255)
            validateLength("token.country_code", startSession.token.countryCode, 2)
            validateLength("token.partyId", startSession.token.partyId, 3)
            validateLength("token.uid", startSession.token.uid, 36)
            validateLength("token.issuer", startSession.token.issuer, 64)
            validateLength("location_id", startSession.locationId, 36)
        }

        val responseType = if (startSession.evseUid == null) {
            // we don't allow remote start on a location. This is an implementation detail on our side
            log.warn("remote start session without evse_id from {}", partnerUrl)
            CommandResponseType.REJECTED
        } else {
            // you either need to store or forward the remote start reference, as we will need it in the session object. 
           async {
                val resultType = ocppClient.remoteStart(startSession.evseUid!!, startSession.token.uid)
                val result = CommandResult(resultType, emptyList())
                commandCpoClient.postCommandCallback(
                    result,
                    partnerUrl,
                    startSession.responseUrl
                )
            }

            CommandResponseType.ACCEPTED
        }

        return OcpiResponseBody.success(CommandResponse(responseType, 30, emptyList()))
    }

[atschabu]

Quality Gate failed

Failed conditions C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

unfortunately I can't see the complaint :/

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[lilgallon]

The quality gate complains about parts of the code like: req.pathParams["authRef"]!!,. There are 7 occurrences.

Map values should be accessed safely. Using the non-null assertion operator here can throw a NullPointerException.

They are all false positive in their context, I fixed them in SonarCloud

[lilgallon]

Great work! Thanks for your contribution