Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TG Mirror] Makes the active sonar stop destroying the game [MDB IGNORE] #82

Closed
wants to merge 1 commit into from

Conversation

ffmirrorbot[bot]
Copy link

@ffmirrorbot ffmirrorbot bot commented Oct 16, 2023

Mirrored on Skyrat: ${this.url}
Original PR: (original url)

About The Pull Request

Hey did you know the active sonar would just repeatedly add mobs to its internal list no matter if they were there already or not?

Yea.

Anyways that's fixed now, overtime is saved

Why It's Good For The Game

image
kylo-kylo-ren

Changelog

🆑 Wallem
fix: The active sonar module won't attempt to create 6000000 new pings per process cycle anymore
/:cl:

… (#24353)

* Makes the active sonar stop destroying the game (#79006)

## About The Pull Request
Hey did you know the active sonar would just repeatedly add mobs to its
internal list no matter if they were there already or not?

Yea.

Anyways that's fixed now, overtime is saved
## Why It's Good For The Game

![image](https://github.com/tgstation/tgstation/assets/66052067/dea57189-034a-46a4-bee3-5d2a1f9eec61)

![kylo-kylo-ren](https://github.com/tgstation/tgstation/assets/66052067/8cbeca30-fd8b-451e-ab61-a91c7192f873)
## Changelog
:cl: Wallem
fix: The active sonar module won't attempt to create 6000000 new pings
per process cycle anymore
/:cl:

* Makes the active sonar stop destroying the game

---------

Co-authored-by: Wallem <[email protected]>
@Iajret Iajret closed this Oct 17, 2023
@Iajret Iajret deleted the upstream-mirror-24353 branch October 17, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants