Use new item list implementation #315
Open
+1,341
−2,109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
use-new-item-list-implementation
branch
6 times, most recently
from
2e6714c to
7c984c9
Compare
sukhwinder33445
force-pushed
the
use-new-item-list-implementation
branch
from
21d099e to
cb4d748
Compare
nilmerg
requested changes
Apr 16, 2025
| { | ||
| public function assembleAttributes($item, Attributes $attributes, string $layout): void | ||
| { | ||
| $attributes->get('class')->addValue('schedule-item'); |
There was a problem hiding this comment.
schedule please. None of the other renderers use -item as suffix either.
There was a problem hiding this comment.
The class schedule is already reserved by the Widget/Schedule. I didn't want to make any changes to Widget/Schedule class.
There was a problem hiding this comment.
I will add a comment here that the suffix is required because the css class is already taken.
OR
Should I change the name of the css in Widget/Schedule to schedule-widget?
There was a problem hiding this comment.
Funny, the ScheduleController already aliases it to ScheduleWidget. I guess now is the time to rename that thing entirely: Icinga\Module\Notifications\Widget\Detail\ScheduleDetail
library/Notifications/ProvidedHook/Notifications/ObjectsRenderer.php
Outdated
Show resolved
Hide resolved
sukhwinder33445
force-pushed
the
use-new-item-list-implementation
branch
from
cb4d748 to
42dc33f
Compare
Closed
|
Fixes #330 |
nilmerg
requested changes
Apr 24, 2025
nilmerg
reviewed
Apr 25, 2025
- Links: Add missing channel links - Remove obsolete code
- Links: Add missing contactAdd() method - Remove obsolete code
- Remove obsolete code
- Remove obsolete code
- Remove obsolete code
- Remove obsolete code
sukhwinder33445
force-pushed
the
use-new-item-list-implementation
branch
2 times, most recently
from
6e5c73f to
75ac72a
Compare
- Remove obsolete code - Adjust Schedule-list.less accordingly
- Remove obsolete code
- Remove obsolete code - ObjectList: Add method to disable action-list functionality
- Remove obsoltete code
This padding is now handled by ipl-web - Optimize code
sukhwinder33445
force-pushed
the
use-new-item-list-implementation
branch
from
75ac72a to
decc109
Compare
ipl-web provide these changes natively with Icinga/ipl-web#273.
- Rename css class to `schedule-detail` _ Move the schedule controls
The .extended-info adds the gap
sukhwinder33445
force-pushed
the
use-new-item-list-implementation
branch
2 times, most recently
from
eaebc58 to
b0ff808
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.