Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 'Adwaita' cursors to the container #19

Closed
wants to merge 1 commit into from

Conversation

Scony
Copy link
Contributor

@Scony Scony commented Apr 17, 2024

Required by WebKit/WebKit#27024

@TingPing
Copy link
Member

The theme is already mounted to /usr/local/share/icons.

We need to figure out why it’s not working.

@Scony
Copy link
Contributor Author

Scony commented Apr 18, 2024

The theme is already mounted to /usr/local/share/icons.

We need to figure out why it’s not working.

It is, but there are no cursors.

@TingPing
Copy link
Member

Can you try setting the XCURSOR_PATH env var to include the /usr/local paths?

@Scony
Copy link
Contributor Author

Scony commented Apr 22, 2024

Can you try setting the XCURSOR_PATH env var to include the /usr/local paths?

I'll try

@Scony
Copy link
Contributor Author

Scony commented May 22, 2024

Can you try setting the XCURSOR_PATH env var to include the /usr/local paths?

It does not change anything. The "cursor lookup" algorithm we have in WebKit starts from /usr/local/share/icons/default anyway.

The problem is that even though we use /usr/local/share/icons/default to find the theme (which we do) following symlinks (/usr/local/share/icons/default/index.theme -> /etc/alternatives/x-cursor-theme -> /usr/share/icons/Adwaita/cursor.theme) we cannot find cursor icons under /usr/share/icons/Adwaita/cursors. This is because the cursors are part of adwaita-icon-theme-full package, see:

$ apt-file list adwaita-icon-theme-full
(...)
adwaita-icon-theme-full: /usr/share/icons/Adwaita/cursors/arrow
adwaita-icon-theme-full: /usr/share/icons/Adwaita/cursors/bd_double_arrow
adwaita-icon-theme-full: /usr/share/icons/Adwaita/cursors/bottom_left_corner
adwaita-icon-theme-full: /usr/share/icons/Adwaita/cursors/bottom_right_corner
adwaita-icon-theme-full: /usr/share/icons/Adwaita/cursors/bottom_side
adwaita-icon-theme-full: /usr/share/icons/Adwaita/cursors/bottom_tee
(...)

@TingPing
Copy link
Member

So ideally we didn't ship any part of Adwaita in the image, but it seems to be a hard dependency on a ton of things.

This works ln -s /usr/local/share/icons/Adwaita/cursors/ /usr/share/icons/Adwaita/cursors

@nikolaszimmermann
Copy link
Member

nikolaszimmermann commented Jun 25, 2024

Oops did not intent to approve sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants