Pass argument '--rm' to avoid wkdev-create container name collission #59
Conversation
|
I'm not sure about this change. What happens if two processes are running this step simultaneously? Giving an unique name to each container guarantees isolation. Perhaps what it makes sense is to have a |
|
I think switching to a tmp dir instead of based on date sounds fine. |
| @@ -85,6 +85,10 @@ process_command_line_arguments() { | |||
| host_hostname="$(hostnamectl hostname)" | |||
| container_hostname="$(basename "${container_name}").${host_hostname}" | |||
|
|
|||
| if argsparse_is_option_set "create-home" && -d "${container_user_home}"; then | |||
| rm -rf "${container_user_home}" | |||
There was a problem hiding this comment.
I was always afraid about adding an option that does an rm -rf :-)
There was a problem hiding this comment.
I think we need a counterpart of wkdev-create but to remove a container.
Now in the runner there's:
$ podman ps
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
97f83258b59f ghcr.io/igalia/wkdev-sdk:latest /wkdev-sdk/script... 3 weeks ago Up 3 weeks ago wkdev-1727468367
fa1c67dc62f4 ghcr.io/igalia/wkdev-sdk:latest /wkdev-sdk/script... 3 weeks ago Up 4 days ago wkdevFor some reason, the temporal container wkdev-1727468367 was not removed.
There was a problem hiding this comment.
We usually used podman rm directly. However, I'm not objecting to a wkdev-destroy script.
Follow-up to d347129.
Command
wkdev-createallows passing argument--rmwhich stops and removes a container in case it already exists. This can be useful to avoid the container name collission, instead of creating a temporal name for the container and stopping and removing it late.To avoid the home directory collission,
wkdev-createcan delete the home directory in case it already exists andcreate-homewas passed as an argument.