Modify container image for bots/infrastructure migration #78
Conversation
These services would start with the container, when using systemd as PID 1 (when not sharing the PID namespace with the host). Avoid that.
One can specify the option multiple times, to pass additional arguments to "podman build".
Allow to override the get_sdk_images_directory(), by specifying the WKDEV_SDK_IMAGES_DIRECTORY environment variable.
Point to webkit-container-sdk, instead of wkdev-sdk, following the rename of the official repository name.
nikolaszimmermann
force-pushed
the
nzimmermann/wkdev_sdk_bots
branch
from
888d3ee
to
9a94192
Compare
| for environment_variable in "${cumulated_values_env[@]}" | ||
| do |
There was a problem hiding this comment.
| for environment_variable in "${cumulated_values_env[@]}" | |
| do | |
| for environment_variable in "${cumulated_values_env[@]}"; do |
There was a problem hiding this comment.
Missed that suggestion, sorry -- will fix it up later.
| # systemd as PID 1 within the container (usually, we don't spawn systemd | ||
| # within the wkdev-sdk container, for interactive usage, but we do so | ||
| # when deploying the wkdev-sdk image as bot). | ||
| RUN find /etc/systemd/ -type l -name '*.service' -print -exec rm {} \; |
There was a problem hiding this comment.
I do worry about this causing an easy to miss issue in the future, however looking at the current services there I don't think there is a problem.
There was a problem hiding this comment.
Also it shouldn't be a problem to actually remove things like cupsd (socket activated anyway) and pipewire from the image, we only use them as clients, if the packages allow that.
Use do use apache for some testing though.
There was a problem hiding this comment.
OK, we can always refine. This is most likely not the last change of this kind.
|
CI fails with |
A bit ironic - that is why we moved to our own runners in the first place 😊 |
|
I manually ran |
|
Oops, I diddn't intend to squash before merging, sorry :/ |
Contains a few individual changes, needed for the bot/infrastructure migration.