Home button reverts Desktop Mode #1117
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pressing the Home button will revert Desktop Mode back to the default. This helps the case where the user is visiting some of the links in the home page, where some of them require Desktop Mode and some don't.
svillar
requested changes
Nov 23, 2023
There was a problem hiding this comment.
The change looks good but I am not sure we want this. The desktop mode is now visible with an icon so the user should be able to see that they are in desktop mode now. Apart from that note that the start page is configurable by the user. They might want the start page to be whatever they want.
If we want to do something we better add some mechanism to automatically exit desktop mode when we have automatically entered it.
|
What should we do with this @felipeerias ? |
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing the Home button will revert Desktop Mode back to the default.
This helps the case where the user is visiting some of the links in the home page, where some of them require Desktop Mode and some don't.