Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RWD fixes, brain is hurting now #238

Merged
merged 2 commits into from
Nov 20, 2024
Merged

RWD fixes, brain is hurting now #238

merged 2 commits into from
Nov 20, 2024

Conversation

meyerweb
Copy link
Member

@meyerweb meyerweb commented Nov 19, 2024

@mariospr
Copy link
Member

@meyerweb I don't understand this PR without further context and with the site preview not working. Could you explain a bit more what you're doing here? Maybe attach an screenshot?

@meyerweb
Copy link
Member Author

@meyerweb I don't understand this PR without further context and with the site preview not working. Could you explain a bit more what you're doing here? Maybe attach an screenshot?

It’s a follow-on to a previous PR that fixes some things; it was meant for Brian’s review, since he has the full context. Sorry it pulled you in!

Copy link
Member

@bkardell bkardell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm... I think there is an apple bug affecting some desktop resizing in safari, but it's minor and would be very rarely seen - we should look into it after...it's better than now, for sure.

@bkardell bkardell merged commit f6fc16c into master Nov 20, 2024
1 check passed
@bkardell bkardell deleted the carousel-rwd branch November 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants