Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix writing results to CSV file #25

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Conversation

acneaguu
Copy link
Member

Updated the collector.py script to write the results under the correct columns in the CSV file. Note: the current implementaiton might be inefficient if the CSV file becomes too big as it reads the file into memory, appends a new row and then writes it again to the disk.

acneaguu and others added 4 commits April 3, 2024 18:46
Fixed a bug where the monitor was writing the CSV file without placing the values under the respective columns. The issue occurs when the order of the inputs of the collected changes slightly between iterations. The fix involves reading the CSV file as a dataframe every time new results are added, which ensures the values are placed under the correct columns, regardless if the column order changes between iterations.
BUGFIX: collector.py to intended behaviour
@acneaguu acneaguu requested review from manuGil and jgrguric96 August 20, 2024 08:26
Copy link
Member

@manuGil manuGil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you review my comments, and resolve the conflicts?
The conflict with the results.csv is not relevant and if restoring the changes to the previous version solve it, that would be enough.

Result/ResidentialCase/results.csv Outdated Show resolved Hide resolved
Models/Controller/controller_mosaik.py Show resolved Hide resolved
Result/MultienergyCase/results.csv Outdated Show resolved Hide resolved
Copy link
Member

@manuGil manuGil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I solved the conflicts. We can merge this.

@manuGil manuGil merged commit 1f4dcba into Illuminator-team:dev Aug 21, 2024
1 check passed
@manuGil manuGil added the bug Something isn't working label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants