-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aligned some features closer to native Ring behavior #19
base: main
Are you sure you want to change the base?
Conversation
Made it so you can directly switch between armed modes without having to disarm first. Also extended it so you could change mode while it's still arming, although this is not currently supported by Alarmo (It simply won't process the new arm service call). Also adjusted the countdown event so it uses the next highest countdown feedback, I think this is better than hardcoding the exact amounts, because the final "armed" or "alarm" event will interrupt it anyway, so even though the countdown doesn't quite get to finish if for example set to 10 seconds and using the 15 second countdown, the behavior is still sensible and better than the fallback error beep. Added panic alarm handling, right now this only sets the alarm to pending, but I am already in touch with the Alarmo devs to get that corrected.
Hi @SEKCobra, have you managed to get those couple of changes merged with the upstream Alarmo? |
Yes, Alarmo is able to go straight into triggered now. Unfortunately my patches have not been integrated to the keypad automations here. |
Would you mind putting a link to the PR here for visibility? Maybe we can show some support for the changes on their GH |
Sorry, I was getting confused myself about the state of things. Alarmo is updated and supports the behavior fully, probably close to two years. |
Many thanks. Ive got v1 myself and i have been using @ImSorryButWho code for long time now, but there are few odd things in the current behaviour which could be better, so i have high hopes regarding this PR |
Removed notes about not being supported by Alarmo, as the feature has been implemented by Alarmo.
Ok, got my bearings back, this is the open pull request implementing the fixes I have made. Unfortunately this pull request is still open and therefore not integrated upstream. |
Made it so you can directly switch between armed modes without having to disarm first. Also extended it so you could change mode while it's still arming, although this is not currently supported by Alarmo (It simply won't process the new arm service call). Also adjusted the countdown event so it uses the next highest countdown feedback, I think this is better than hardcoding the exact amounts, because the final "armed" or "alarm" event will interrupt it anyway, so even though the countdown doesn't quite get to finish if for example set to 10 seconds and using the 15 second countdown, the behavior is still sensible and better than the fallback error beep. Added panic alarm handling, right now this only sets the alarm to pending, but I am already in touch with the Alarmo devs to get that corrected.