Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IECoreVDB : Python bindings renamed from pyopenvdb to openvdb in later versions #1455

Open
wants to merge 1 commit into
base: RB-10.5
Choose a base branch
from

Conversation

boberfly
Copy link
Contributor

@boberfly boberfly commented Mar 7, 2025

Generally describe what this PR will do, and why it is needed.

  • If pyopenvdb fails, try the renamed openvdb in later versions in a try/except.

Related Issues

  • NA

Dependencies

  • OpenVDB 12 (maybe 11?) but this change just adds support for the module rename, the old one will work.

Breaking Changes

  • NA

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Cortex project's prevailing coding style and conventions.

@johnhaddon
Copy link
Member

Thanks Alex! It looks like OpenVDB 12 also switches the Python bindings from pybind11 to nano bind - do you know how that affects our interoperability bindings in https://github.com/ImageEngine/cortex/blob/main/src/IECoreVDB/bindings/IECoreVDBModule.cpp?

@boberfly
Copy link
Contributor Author

boberfly commented Mar 7, 2025

Good question, I can tell you it still compiled fine but I'll do some closer testing here or run the unit tests.

@boberfly
Copy link
Contributor Author

boberfly commented Mar 9, 2025

Turns out Cortex just silently didn't build OpenVDB from the logs. I started to make a NanoBindConverter.h and some plumbing for nanobind however I can't quite get the casting right and the porting guide from their documentation isn't too clear to me (I've made comments to those parts).

https://nanobind.readthedocs.io/en/latest/porting.html#type-casters

…ython bindings renamed from pyopenvdb to openvdb in later versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants