Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Missing "version" property when writing measure script files #701

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

alexdewar
Copy link
Collaborator

As this is a bug, I thought it best to try to merge a fix ASAP so it doesn't get in the way of development.

As @dalonsoa suggested, it would be better if we had a unit test that checks whether the measure script YAML files we're saving are actually valid according to the schema, but I didn't have time to do this properly now, so I've opened an issue: #700.

Fixes #699.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.30%. Comparing base (23f81ad) to head (1c1fb22).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #701   +/-   ##
=======================================
  Coverage   86.30%   86.30%           
=======================================
  Files          69       69           
  Lines        3549     3549           
=======================================
  Hits         3063     3063           
  Misses        486      486           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexdewar alexdewar merged commit e2033cf into main Nov 11, 2024
7 checks passed
@alexdewar alexdewar deleted the fix-write-version-property-measure-scripts branch November 11, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write version field to measure scripts
3 participants