Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Python v3.13 #751

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Update to Python v3.13 #751

merged 1 commit into from
Dec 19, 2024

Conversation

alexdewar
Copy link
Collaborator

Description

There seems like no better time to do this. I've done some manual testing with Python 3.13 and everything still seems to work as expected (except for the bug fixed in #750).

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation (non-breaking change that adds or improves the documentation)
  • Optimisation (non-breaking, back-end change that speeds up the code)

Key checklist

  • Pre-commit hooks run successfully (pre-commit run -a)
  • All tests pass (pytest)
  • The documentation builds without warnings (mkdocs build -s)
  • Check the GUI still works (if relevant)
  • Check the code works with actual hardware (if relevant)
  • Check the pyinstaller-built executable works (if relevant)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests have been added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@alexdewar alexdewar requested review from dalonsoa and dc2917 December 18, 2024 16:06
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.94%. Comparing base (6680116) to head (6c89208).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #751   +/-   ##
=======================================
  Coverage   86.94%   86.94%           
=======================================
  Files          69       69           
  Lines        3561     3561           
=======================================
  Hits         3096     3096           
  Misses        465      465           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, all good! I guess not tested in a real system, right? I'm just a bit worried because of the serial library...

@alexdewar
Copy link
Collaborator Author

Nope, just with dummy devices 😞.

I'd be happier if it were tested on the real hardware too, but as we won't have access to it for a while, I think it's probably just ok to merge it and fix things later if needed. Jon has offered to do some testing in the meantime -- I'll make an rc release to send him.

I have checked and no one's complaining about PySerial not working on Python 3.13, so that's something.

@alexdewar alexdewar merged commit ab014ef into main Dec 19, 2024
7 checks passed
@alexdewar alexdewar deleted the python313 branch December 19, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants