Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fill in valuation_comap #194

Merged
merged 6 commits into from
Nov 12, 2024
Merged

fill in valuation_comap #194

merged 6 commits into from
Nov 12, 2024

Conversation

erdOne
Copy link
Contributor

@erdOne erdOne commented Nov 4, 2024

No description provided.

@erdOne erdOne changed the title stash fill in valuation_comap Nov 11, 2024
@erdOne erdOne marked this pull request as ready for review November 11, 2024 17:08
@erdOne
Copy link
Contributor Author

erdOne commented Nov 11, 2024

The right thing to do is probably to generalize HeightOneSpectrum.valuation to take in any ideal...

@kbuzzard
Copy link
Collaborator

So what is the 6-adic valuation of 2, of 3 and of 6?

@erdOne
Copy link
Contributor Author

erdOne commented Nov 11, 2024 •
edited
Loading

No I mean given a prime there should be a valuation from the fractional ideas to Z, and not merely from K^x.

@kbuzzard
Copy link
Collaborator

Thanks!

@kbuzzard kbuzzard merged commit 409509d into ImperialCollegeLondon:main Nov 12, 2024
1 check passed
@Ruben-VandeVelde Ruben-VandeVelde mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erdOne @kbuzzard