Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dict as info field #159

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Allow dict as info field #159

merged 2 commits into from
Oct 24, 2024

Conversation

tomjholland
Copy link
Collaborator

This pull request includes several changes to the pyprobe package, primarily focusing on enhancing type annotations and simplifying class structures. The most important changes involve updating the info field to support nested dictionaries and removing re-definitions of inherited attributes from multiple classes.

Type Annotations and Field Updates:

  • pyprobe/cell.py: Updated the info field in the Cell class to support nested dictionaries. This change is reflected in the type annotations and the corresponding field validator. [1] [2] [3]

Codebase Simplification:

  • pyprobe/filters.py: Removed inherited attributes such as base_dataframe, info, and column_definitions from multiple classes (Procedure, Experiment, Cycle, Step). This helps in simplifying the class definitions and reducing clutter. [1] [2] [3] [4]
  • pyprobe/rawdata.py: Removed the base_dataframe and info attributes from the RawData class and added a detailed docstring for the step_descriptions attribute.

Additional Changes:

  • pyprobe/result.py: Updated the info field in the Result class to support nested dictionaries and adjusted the type annotations accordingly. [1] [2]
  • pyprobe/filters.py: Removed the import of Field from pydantic as it is no longer needed.

@tomjholland tomjholland added feature Adding a new functionality, small or large refactor Refactoring existing code without significantly changing functionality labels Oct 24, 2024
@tomjholland tomjholland merged commit f99377b into main Oct 24, 2024
2 checks passed
@tomjholland tomjholland deleted the allow-dict-as-info-field branch October 24, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding a new functionality, small or large refactor Refactoring existing code without significantly changing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant