Add group members view with permission checks

[HarmonicReflux]

Description

• Implement group_members_view to display members of a research group based on the GroupMember model.
• Added permission checks to allow access only for the group owner or an admin.
• Included check for PI (Principal Investigator) status to ensure group ownership.
• Render group_members.html for authorised users; display no_group.html with a message for non-PI users.

Fixes #18, #34.

Type of change

• Documentation (non-breaking change that adds or improves the documentation)
• New feature (non-breaking change which adds functionality)
• Optimization (non-breaking, back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)
• Breaking change (whatever its nature)

Key checklist

• All tests pass (eg. python -m pytest)
• The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
• Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

[cc-a]

Based on our session yesterday you're hopefully now able to try this out in the browser @HarmonicReflux?

[HarmonicReflux]

I am getting closer @cc-a , but encounter this error int eh CI/CD tests:

I import admin using the codebase we already have, i.e. like so
from django.contrib import admin
so not sure why the error is thrown.

[cc-a]

I've taken the liberty of pushing a couple of commits. The first addresses the issue you reported by updating the settings used during tests to include the django.contrib.auth module. This came up now as we added some functionality using the admin module. An unfortunate clunky artifact on of how standalone Django apps work.

I then hit a subsequent issue with mypy that I was unable to resolve. I'm going to create a follow up issue to look into how to deal with these mypy issues properly but have disabled the mypy checks for now. Maybe I'm just missing something but I'm increasingly dubious of the merits of using mypy with Django.

[HarmonicReflux]

Thanks for this.

Well, as per out discussions in person and online, maybe its best to deactivate mypy for this project entirely .
I think insufficient support of non-primitive types in Python are a "limitation of the language on purpose". If they are more pain than good for this project, disabling them may be our best bet, but that is just my opinion.

It is certainly worth looking into it in more detail so we have a good assessment of the technical debt we incur switching mypy off.

[AdrianDAlessandro]

I can't work out how to test this. How do I access the view?

[SaranjeetKaur]

A question: Is a new file generated in the migrations/ folder each time makemigrations.py is run? For example, in this PR there is a new file migrations/0003_remove_groupmembership_owner_researchgroup_and_more.py.

[AdrianDAlessandro]

A question: Is a new file generated in the migrations/ folder each time makemigrations.py is run? For example, in this PR there is a new file migrations/0003_remove_groupmembership_owner_researchgroup_and_more.py.

Yes, if there are changes to the models then we need to make migrations, which are then saved in migrations/

[cc-a]

@AdrianDAlessandro Unfortunately you'll have to type the url in manually. Until we get #21 there is nowhere obvious to put the link.

[cc-a]

We'll need some tests for this but let's do that in follow up PR.

[AdrianDAlessandro]

@AdrianDAlessandro Unfortunately you'll have to type the url in manually. Until we get #21 there is nowhere obvious to put the link.

I went to /group/1/members/ and it wasn't a valid URL. Am I doing something wrong there?

[cc-a]

@AdrianDAlessandro I think you need to go to icl/group/1/members/ as all of the plugin urls are added to Coldfront under a prefix.

[AdrianDAlessandro]

Ok, I managed to work out I need to navigate to http://127.0.0.1:8000/icl/group/1/members/ and it worked for when I wasn't a PI. But after setting is_pi to True it failed with this error (I believe the same error mypy was showing):

...
  File "/usr/src/imperial_coldfront_plugin/imperial_coldfront_plugin/views.py", line 51, in group_members_view
    group_members = GroupMembership.objects.filter(owner=user)
...
FieldError at /icl/group/1/members/
Cannot resolve keyword 'owner' into field. Choices are: group, group_id, id, member, member_id

[AdrianDAlessandro]

This feels wrong... Shouldn't we be using get_user_model() directly each time?

[AdrianDAlessandro]

Why can only superusers can view this?

[AdrianDAlessandro]

Is this userprofile a field provided by coldfront?