Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support making migrations #37

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Support making migrations #37

merged 5 commits into from
Nov 18, 2024

Conversation

cc-a
Copy link
Collaborator

@cc-a cc-a commented Nov 18, 2024

Description

This pull request includes the addition of a new script and corresponding documentation to facilitate making migrations in a standalone Django application. The most important changes include adding a helper script for generating migrations and updating the README file with instructions on how to use this script.

Fixes #25

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

Copy link

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work nicely

@@ -66,7 +68,7 @@ module = ["imperial_coldfront_plugin.oidc"]
disallow_any_explicit = false

[tool.pytest.ini_options]
addopts = "-v --mypy -p no:warnings --cov=imperial_coldfront_plugin --cov-report=html --doctest-modules --ignore=docs"
addopts = "-v --mypy -p no:warnings --cov=imperial_coldfront_plugin --cov-report=html --doctest-modules --ignore=docs --ignore=makemigrations.py"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to also ignore the migrations folder itself when we make one

@cc-a cc-a enabled auto-merge November 18, 2024 16:44
@cc-a cc-a merged commit 231219f into main Nov 18, 2024
3 checks passed
@cc-a cc-a deleted the makemigrations branch November 18, 2024 16:45
Copy link
Contributor

@HarmonicReflux HarmonicReflux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in coldfront meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a way to access Django Management commands
3 participants