Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hatchling #128

Merged
merged 3 commits into from
Nov 27, 2024
Merged

hatchling #128

merged 3 commits into from
Nov 27, 2024

Conversation

barneydobson
Copy link
Collaborator

@barneydobson barneydobson commented Nov 22, 2024

Fixes #127

More or less copied from SWMManywhere - I guess lets see if it works

copied from sa
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of extra changes you need to do to make this work:

  • The version should be removed and used instead dynamic = [ "version"], as done in SWMManywhere
  • You might need to implement a more complex code coverage setup, but I'm not sure if that was required because of hatching or because of having the code within a src folder.

I'd suggest you try to run hatch build and check if the wheel created actually works as expected.

version to dynamic
@barneydobson
Copy link
Collaborator Author

barneydobson commented Nov 26, 2024

OK good point on version - I'm inclined to just give it a try RE coverage and see what happens.

hatch build does work, though it also worked before changing version

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good! Let's go for it and see what happens.

@barneydobson barneydobson merged commit 8678437 into main Nov 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue releasing to pypi
2 participants