Skip to content

Commit

Permalink
Bug fixed:
Browse files Browse the repository at this point in the history
・ライブラリNewtonsoft.Jsonのバージョンアップに対応。
・サイトパッケージにインポート時にKeyNotFoundExceptionが発生する問題を解消。
・項目の制御を含まない状況による制御が設定されたテーブルで自動ポストバック時にnull参照違反が発生する問題を解消。
  • Loading branch information
implem-noro committed Dec 9, 2022
1 parent d1fd101 commit 02d84f9
Show file tree
Hide file tree
Showing 17 changed files with 70 additions and 65 deletions.
6 changes: 3 additions & 3 deletions Implem.CodeDefiner/Implem.CodeDefiner.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
<TargetFramework>net6.0</TargetFramework>
<Copyright>Copyright © Implem Inc 2014 - 2022</Copyright>
<Description>This program does the automatic code creation and merging of existing code based on the definition. Also it will make the configuration change of sql server database.</Description>
<AssemblyVersion>1.3.26.0</AssemblyVersion>
<FileVersion>1.3.26.0</FileVersion>
<Version>1.3.26.0</Version>
<AssemblyVersion>1.3.26.1</AssemblyVersion>
<FileVersion>1.3.26.1</FileVersion>
<Version>1.3.26.1</Version>
<DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions Implem.DefinitionAccessor/Implem.DefinitionAccessor.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<Copyright>Copyright © Implem Inc 2014 - 2022</Copyright>
<AssemblyVersion>1.3.26.0</AssemblyVersion>
<FileVersion>1.3.26.0</FileVersion>
<Version>1.3.26.0</Version>
<AssemblyVersion>1.3.26.1</AssemblyVersion>
<FileVersion>1.3.26.1</FileVersion>
<Version>1.3.26.1</Version>
<Nullable>disable</Nullable>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions Implem.DisplayAccessor/Implem.DisplayAccessor.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<Copyright>Copyright © Implem Inc 2014 - 2022</Copyright>
<AssemblyVersion>1.3.26.0</AssemblyVersion>
<FileVersion>1.3.26.0</FileVersion>
<Version>1.3.26.0</Version>
<AssemblyVersion>1.3.26.1</AssemblyVersion>
<FileVersion>1.3.26.1</FileVersion>
<Version>1.3.26.1</Version>
<Nullable>disable</Nullable>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions Implem.Factory/Implem.Factory.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<Copyright>Copyright © Implem Inc 2014 - 2022</Copyright>
<AssemblyVersion>1.3.26.0</AssemblyVersion>
<FileVersion>1.3.26.0</FileVersion>
<Version>1.3.26.0</Version>
<AssemblyVersion>1.3.26.1</AssemblyVersion>
<FileVersion>1.3.26.1</FileVersion>
<Version>1.3.26.1</Version>
<Nullable>disable</Nullable>
</PropertyGroup>

Expand Down
8 changes: 4 additions & 4 deletions Implem.Libraries/Implem.Libraries.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<Copyright>Copyright © Implem Inc 2014 - 2022</Copyright>
<AssemblyVersion>1.3.26.0</AssemblyVersion>
<FileVersion>1.3.26.0</FileVersion>
<Version>1.3.26.0</Version>
<AssemblyVersion>1.3.26.1</AssemblyVersion>
<FileVersion>1.3.26.1</FileVersion>
<Version>1.3.26.1</Version>
<Nullable>disable</Nullable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="CsvHelper" Version="15.0.3" />
<PackageReference Include="DocumentFormat.OpenXml" Version="2.17.1" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
<PackageReference Include="System.Drawing.Common" Version="5.0.3" />
<PackageReference Include="System.IO.FileSystem.Primitives" Version="4.3.0" />
<PackageReference Include="System.ValueTuple" Version="4.5.0" />
Expand Down
6 changes: 3 additions & 3 deletions Implem.ParameterAccessor/Implem.ParameterAccessor.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<Copyright>Copyright © Implem Inc 2014 - 2022</Copyright>
<AssemblyVersion>1.3.26.0</AssemblyVersion>
<FileVersion>1.3.26.0</FileVersion>
<Version>1.3.26.0</Version>
<AssemblyVersion>1.3.26.1</AssemblyVersion>
<FileVersion>1.3.26.1</FileVersion>
<Version>1.3.26.1</Version>
<Nullable>disable</Nullable>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
public void SetPostedFiles(
public void SetPostedFile(
Microsoft.AspNetCore.Http.IFormFile file,
string columnName,
Shared._ImageApiModel image)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
var file = new Microsoft.AspNetCore.Http.FormFile(stream, 0, bytes.Length, null, $"image{o.Value.Extension}");
if (ss.ColumnHash.Get(o.Key).AllowImage == true)
{
SetPostedFiles(
SetPostedFile(
file: file,
columnName: o.Key,
image: o.Value);
Expand Down
8 changes: 4 additions & 4 deletions Implem.Pleasanter/Implem.Pleasanter.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
<Copyright>Copyright © Implem Inc 2014 - 2022</Copyright>
<Description>Business application platform</Description>
<AssemblyName>Implem.Pleasanter</AssemblyName>
<AssemblyVersion>1.3.26.0</AssemblyVersion>
<FileVersion>1.3.26.0</FileVersion>
<AssemblyVersion>1.3.26.1</AssemblyVersion>
<FileVersion>1.3.26.1</FileVersion>
<LangVersion>7.2</LangVersion>
<Version>1.3.26.0</Version>
<Version>1.3.26.1</Version>
<Nullable>disable</Nullable>
<DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
<DockerComposeProjectPath>..\docker-compose.dcproj</DockerComposeProjectPath>
Expand Down Expand Up @@ -61,7 +61,7 @@
<PackageReference Include="Microsoft.Web.Infrastructure" Version="2.0.0">
<NoWarn>NU1701</NoWarn>
</PackageReference>
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
<PackageReference Include="Novell.Directory.Ldap.NETStandard" Version="3.6.0" />
<PackageReference Include="Sendgrid" Version="9.28.1" />
<PackageReference Include="SendGrid.SmtpApi" Version="1.4.6" />
Expand Down
1 change: 1 addition & 0 deletions Implem.Pleasanter/Libraries/Settings/SiteSettings.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5306,6 +5306,7 @@ public List<string> ReplaceFieldColumns(
.Where(o => o.UseSearch == true)
.Select(o => o.ColumnName));
columns.AddRange(StatusControls?
.Where(statusControl => statusControl.ColumnHash != null)
.SelectMany(statusControl => statusControl.ColumnHash)
.Where(o => o.Value != StatusControl.ControlConstraintsTypes.None)
.Select(o => o.Key));
Expand Down
50 changes: 27 additions & 23 deletions Implem.Pleasanter/Libraries/SitePackages/Utilities.cs
Original file line number Diff line number Diff line change
Expand Up @@ -339,33 +339,37 @@ public static string ImportSitePackage(
continue;
}
}
var idConverter = new IdConverter(
context: context,
siteId: packageSiteModel.SavedSiteId,
permissionShortModel: permissionShortModel,
permissionIdList: sitePackage.PermissionIdList,
convertSiteId: idHash[permissionShortModel.ReferenceId]);
var exists = Rds.ExecuteScalar_int(
context: context,
statements: Rds.SelectPermissions(
column: Rds.PermissionsColumn().ReferenceId(),
where: Rds.PermissionsWhere()
.ReferenceId(idHash[permissionShortModel.ReferenceId])
.DeptId(idConverter.ConvertDeptId)
.GroupId(idConverter.ConvertGroupId)
.UserId(idConverter.ConvertUserId))) > 0;
if (idConverter.Convert == true && !exists)
var referenceId = idHash.Get(permissionShortModel.ReferenceId);
if (referenceId > 0)
{
Repository.ExecuteNonQuery(
var idConverter = new IdConverter(
context: context,
siteId: packageSiteModel.SavedSiteId,
permissionShortModel: permissionShortModel,
permissionIdList: sitePackage.PermissionIdList,
convertSiteId: referenceId);
var exists = Rds.ExecuteScalar_int(
context: context,
transactional: true,
statements: Rds.InsertPermissions(
param: Rds.PermissionsParam()
.ReferenceId(idHash[permissionShortModel.ReferenceId])
statements: Rds.SelectPermissions(
column: Rds.PermissionsColumn().ReferenceId(),
where: Rds.PermissionsWhere()
.ReferenceId(referenceId)
.DeptId(idConverter.ConvertDeptId)
.GroupId(idConverter.ConvertGroupId)
.UserId(idConverter.ConvertUserId)
.PermissionType(permissionShortModel.PermissionType)));
.UserId(idConverter.ConvertUserId))) > 0;
if (idConverter.Convert == true && !exists)
{
Repository.ExecuteNonQuery(
context: context,
transactional: true,
statements: Rds.InsertPermissions(
param: Rds.PermissionsParam()
.ReferenceId(referenceId)
.DeptId(idConverter.ConvertDeptId)
.GroupId(idConverter.ConvertGroupId)
.UserId(idConverter.ConvertUserId)
.PermissionType(permissionShortModel.PermissionType)));
}
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions Implem.Pleasanter/Models/Issues/IssueModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3045,7 +3045,7 @@ public void SetByApi(Context context, SiteSettings ss)
var file = new Microsoft.AspNetCore.Http.FormFile(stream, 0, bytes.Length, null, $"image{o.Value.Extension}");
if (ss.ColumnHash.Get(o.Key).AllowImage == true)
{
SetPostedFiles(
SetPostedFile(
file: file,
columnName: o.Key,
image: o.Value);
Expand All @@ -3061,7 +3061,7 @@ public void SetByApi(Context context, SiteSettings ss)
SetChoiceHash(context: context, ss: ss);
}

public void SetPostedFiles(
public void SetPostedFile(
Microsoft.AspNetCore.Http.IFormFile file,
string columnName,
Shared._ImageApiModel image)
Expand Down
4 changes: 2 additions & 2 deletions Implem.Pleasanter/Models/Results/ResultModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2743,7 +2743,7 @@ public void SetByApi(Context context, SiteSettings ss)
var file = new Microsoft.AspNetCore.Http.FormFile(stream, 0, bytes.Length, null, $"image{o.Value.Extension}");
if (ss.ColumnHash.Get(o.Key).AllowImage == true)
{
SetPostedFiles(
SetPostedFile(
file: file,
columnName: o.Key,
image: o.Value);
Expand All @@ -2759,7 +2759,7 @@ public void SetByApi(Context context, SiteSettings ss)
SetChoiceHash(context: context, ss: ss);
}

public void SetPostedFiles(
public void SetPostedFile(
Microsoft.AspNetCore.Http.IFormFile file,
string columnName,
Shared._ImageApiModel image)
Expand Down
8 changes: 4 additions & 4 deletions Implem.TestAutomation/implem.TestAutomation.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<Copyright>Copyright © Implem Inc 2014 - 2022</Copyright>
<AssemblyVersion>1.3.26.0</AssemblyVersion>
<FileVersion>1.3.26.0</FileVersion>
<Version>1.3.26.0</Version>
<AssemblyVersion>1.3.26.1</AssemblyVersion>
<FileVersion>1.3.26.1</FileVersion>
<Version>1.3.26.1</Version>
<DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
</PropertyGroup>

Expand All @@ -24,7 +24,7 @@
<PackageReference Include="AspNetCoreCurrentRequestContext" Version="2.0.0" />
<PackageReference Include="CsvHelper" Version="27.1.1" />
<PackageReference Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.17.0" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
<PackageReference Include="Selenium.Support" Version="4.4.0" />
<PackageReference Include="Selenium.WebDriver" Version="4.4.0" />
<PackageReference Include="Selenium.WebDriver.ChromeDriver" Version="106.0.5249.6100" />
Expand Down
6 changes: 3 additions & 3 deletions Rds/Implem.IRds/Implem.IRds.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<Copyright>Copyright © Implem Inc 2014 - 2022</Copyright>
<AssemblyVersion>1.3.26.0</AssemblyVersion>
<FileVersion>1.3.26.0</FileVersion>
<Version>1.3.26.0</Version>
<AssemblyVersion>1.3.26.1</AssemblyVersion>
<FileVersion>1.3.26.1</FileVersion>
<Version>1.3.26.1</Version>
<Nullable>disable</Nullable>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions Rds/Implem.PostgreSql/Implem.PostgreSql.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<Copyright>Copyright © Implem Inc 2014 - 2022</Copyright>
<AssemblyVersion>1.3.26.0</AssemblyVersion>
<FileVersion>1.3.26.0</FileVersion>
<Version>1.3.26.0</Version>
<AssemblyVersion>1.3.26.1</AssemblyVersion>
<FileVersion>1.3.26.1</FileVersion>
<Version>1.3.26.1</Version>
<Nullable>disable</Nullable>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions Rds/Implem.SqlServer/Implem.SqlServer.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<Copyright>Copyright © Implem Inc 2014 - 2022</Copyright>
<AssemblyVersion>1.3.26.0</AssemblyVersion>
<FileVersion>1.3.26.0</FileVersion>
<Version>1.3.26.0</Version>
<AssemblyVersion>1.3.26.1</AssemblyVersion>
<FileVersion>1.3.26.1</FileVersion>
<Version>1.3.26.1</Version>
<Nullable>disable</Nullable>
</PropertyGroup>

Expand Down

0 comments on commit 02d84f9

Please sign in to comment.