-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add europeana cho data #20
base: main
Are you sure you want to change the base?
Conversation
Ah, I'll have to do some fixes to the data (based on shacl errors) before review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you have a look if I am right and the link to the persons is missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell the data on the producing artists seems to be missing. There is production events and from the production a bioc:had_participant_in_role
, but the role and the E21_Person seem to be missing. I think thats why the new data is still not showing up in the network visualizations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some data on the Role (rdf:type) and Person (bioc:bearer_of and owl:sameAs) instances in the data. But what is missing, are the rdf:type triples for Persons:
[person] a E21_Person
[person] a idmcore:Person_Proxy .
I will add these. Let me know if there are some other properties that are missing, and should be added.
Here's an example of the current data:
<https://www.intavia.eu/production_event/data.europeana.eu/proxy/europeana/91627/SMVK_EM_fotografi_1855313>
rdf:type crm:E12_Production;
bioc:had_participant_in_role <https://www.intavia.org/idm/role/producing_artist/www.wikidata.org/entity/Q15998678>;
bioc:occured_in_the_presence_of_in_role
<https://www.intavia.org/idm/role/produced_cho/data.europeana.eu/proxy/europeana/91627/SMVK_EM_fotografi_1855313>;
crm:P11_had_participant <http://data.europeana.eu/agent/base/144676>;
crm:P7_took_place_at <http://data.europeana.eu/place/base/216254> .
<https://www.intavia.org/idm/role/producing_artist/www.wikidata.org/entity/Q15998678>
rdf:type idmrole:producing_artist .
<http://data.europeana.eu/agent/base/144676>
bioc:bearer_of <https://www.intavia.org/idm/role/producing_artist/www.wikidata.org/entity/Q15998678>;
owl:sameAs <http://www.wikidata.org/entity/Q15998678> .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm: the rdf:type triples for Persons were added in
afcdd39
…nces; add rdf:type idmcore:Place_Proxy to place instances; fix creation of time-spans; add rdfs:label for persons; add rdfs:label for places which have a uri in europeana; create unique uris for producing_artist roles
I made fixes to timespans: crm:P82a/P82b values have now valid datatypes (invalid values - values that cannot be presented as xsd:dateTime, xsd:date or xsd:gYear - are discarded and only added as rdfs:label of the timespan). The SHACL validation GitHub Action seems to be broken:
Can you have a look at this @sennierer? |
restarted the action and it worked. no idea why it didnt in the first run |
No description provided.