Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add europeana cho data #20

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add europeana cho data #20

wants to merge 5 commits into from

Conversation

yoge1
Copy link

@yoge1 yoge1 commented Oct 25, 2023

No description provided.

@yoge1 yoge1 requested a review from sennierer October 25, 2023 14:56
@yoge1
Copy link
Author

yoge1 commented Oct 25, 2023

Ah, I'll have to do some fixes to the data (based on shacl errors) before review and merge.

@yoge1 yoge1 removed the request for review from sennierer October 25, 2023 15:06
@yoge1 yoge1 requested a review from sennierer October 26, 2023 06:55
Copy link
Member

@sennierer sennierer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have a look if I am right and the link to the persons is missing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell the data on the producing artists seems to be missing. There is production events and from the production a bioc:had_participant_in_role, but the role and the E21_Person seem to be missing. I think thats why the new data is still not showing up in the network visualizations.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some data on the Role (rdf:type) and Person (bioc:bearer_of and owl:sameAs) instances in the data. But what is missing, are the rdf:type triples for Persons:

[person] a E21_Person
[person] a idmcore:Person_Proxy .

I will add these. Let me know if there are some other properties that are missing, and should be added.

Here's an example of the current data:

<https://www.intavia.eu/production_event/data.europeana.eu/proxy/europeana/91627/SMVK_EM_fotografi_1855313>
        rdf:type                      crm:E12_Production;
        bioc:had_participant_in_role  <https://www.intavia.org/idm/role/producing_artist/www.wikidata.org/entity/Q15998678>;
        bioc:occured_in_the_presence_of_in_role
                <https://www.intavia.org/idm/role/produced_cho/data.europeana.eu/proxy/europeana/91627/SMVK_EM_fotografi_1855313>;
        crm:P11_had_participant       <http://data.europeana.eu/agent/base/144676>;
        crm:P7_took_place_at          <http://data.europeana.eu/place/base/216254> .

<https://www.intavia.org/idm/role/producing_artist/www.wikidata.org/entity/Q15998678>
        rdf:type  idmrole:producing_artist .

<http://data.europeana.eu/agent/base/144676>
        bioc:bearer_of  <https://www.intavia.org/idm/role/producing_artist/www.wikidata.org/entity/Q15998678>;
        owl:sameAs      <http://www.wikidata.org/entity/Q15998678> .

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm: the rdf:type triples for Persons were added in
afcdd39

yoge1 added 2 commits October 30, 2023 17:16
…nces; add rdf:type idmcore:Place_Proxy to place instances; fix creation of time-spans; add rdfs:label for persons; add rdfs:label for places which have a uri in europeana; create unique uris for producing_artist roles
@yoge1
Copy link
Author

yoge1 commented Nov 2, 2023

I made fixes to timespans: crm:P82a/P82b values have now valid datatypes (invalid values - values that cannot be presented as xsd:dateTime, xsd:date or xsd:gYear - are discarded and only added as rdfs:label of the timespan).

The SHACL validation GitHub Action seems to be broken:

Run /home/runner/work/_actions/konradhoeffner/shacl/master/entrypoint.sh "IKG_shacl_shapes.ttl" "datasets/europeana-cho-idm.ttl" ""
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.12.0/x64/bin/pyshacl", line 5, in <module>
    from pyshacl.cli import main
  File "/opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/site-packages/pyshacl/__init__.py", line 5, in <module>
    from .validate import Validator, validate
  File "/opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/site-packages/pyshacl/validate.py", line 28, in <module>
    from .extras import check_extra_installed
  File "/opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/site-packages/pyshacl/extras/__init__.py", line 6, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

Can you have a look at this @sennierer?

@sennierer
Copy link
Member

restarted the action and it worked. no idea why it didnt in the first run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants