-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: replace custom types with Pydantic 2 #335
base: elias/typing
Are you sure you want to change the base?
Conversation
@CodiumAI-Agent /review |
PR Reviewer Guide 🔍(Review updated until commit cd974c0)Here are some key observations to aid the review process:
|
Y'all can ignore this was just curious to test this thing out and needed a PR on a public repo |
Persistent review updated to latest commit cd974c0 |
i accept guinea pig status |
Summary
Replacing all the custom type parsing stuff with Pydantic 2.
Based on my existing static typing branch, so that will have to get merged first.
Pydantic parses a few things slightly differently than we were, namely datetimes, so I've patched that validation to ensure backwards compat:
Also fixed some deprecations.
Type of change