-
Notifications
You must be signed in to change notification settings - Fork 72
Core api update serial #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: core-api-update
Are you sure you want to change the base?
Conversation
Signed-off-by: zhanglinjing <[email protected]>
Signed-off-by: zhanglinjing <[email protected]>
Signed-off-by: zhanglinjing <[email protected]>
Signed-off-by: zhanglinjing <[email protected]>
Signed-off-by: zhanglinjing <[email protected]>
66d25a1
to
eb65b85
Compare
Signed-off-by: zhanglinjing <[email protected]>
Signed-off-by: zhanglinjing <[email protected]>
01f24a8
to
79a1e99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be tested closely as I don't know what might be the implications of a serialEvent inside the main.cpp. BTW, is it true that there was no Uart inside the xmc core?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested in XMC4700 kit this implementation. test cases not get hanged, its running continuously.
@LinjingZhang please check the relevant UART comments in #343. |
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Serial module Implementation
Related Issue
Bug: https://jirard.intra.infineon.com/browse/DESMAKERS-4557
Context
Now only have ringbuffer for receiving, for sending, its write immediately.
If you check the API description for XMC_UART_CH_Transmit(): Before putting data to TBUF, the API waits for TBUF to finish shifting its contents to shift register. So user can continuously execute the API without checking for TBUF busy status We @OlafFilies had a discuss before.
Code is simple and understandable.