You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Complete state of the step can now be set by new complete prop on every step.
And every complete step's label can be clicked to navigate to that step.
Enhanced accessibility of the component.
@akashyeole
In addition to what we already discussed:
add the emitted events in storybook + event description. Look at the example of how it's done with other components
complete prop is not listed in the storybook page as an option
create an internal state for activeStep prop. Props should not be mutated.
active step cannot be error. When you set error to true on active step, the label becomes red, but indicator remains active. This should not be the case. Error should have no effect on an active step.
rename event name from ifxActiveStepChange to just ifxChange.
the 'activeStep' and 'previousStep' properties of the event object are not numbers showing the active step, but instead
the stepper component itself.
when I increment the active step, the previous one becomes 'error' by default. It should be completed by default. All the
steps prior to the current active one are by default 'completed'.
too many unnecessary comments for every prop/state/statement
the 'activeStep' and 'previousStep' properties of the event object are not numbers showing the active step, but instead the stepper component itself.
Fixed - now the activeStep and previousStep properties of the event object are numbers.
when I increment the active step, the previous one becomes 'error' by default. It should be completed by default. All the steps prior to the current active one are by default 'completed'.
Whenever the step is changed, if the previous step is incomplete it will become error by default - this is the current logic because of which the previous step becomes error. So, user has to mark the step complete explicitly using step.complete = true.
Note - On load time all the steps before active step will be complete by default.
too many unnecessary comments for every prop/state/statement
The comments above every prop will assist the developer to understand its use in a code editor itself. Please see the image
I will remove them if you want.
use ifx-link for the labels
Fixed - used ifx-links (underlined variant) in default stepper variant.
1 - when showNumber is true, the number appears on every step, even on the currently active one, thus overriding the activeStep state. This should not be the case. The currently active Step state should not be overridden by the number.
2 - variant by default should be 'default'. If no variant is specified, it should be the 'default' one. Currently, if no variant is specified, the component does not render.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Complete state of the step can now be set by new
completeprop on every step.And every complete step's label can be clicked to navigate to that step.
Enhanced accessibility of the component.
Related Issue
#1307
📦 Published PR as canary version:
23.4.0--canary.1331.8e7a4869076662c8bb756c563db5831fea87a23c.0✨ Test out this PR locally via:
npm install @infineon/infineon-design-system-stencil@23.4.0--canary.1331.8e7a4869076662c8bb756c563db5831fea87a23c.0 # or yarn add @infineon/infineon-design-system-stencil@23.4.0--canary.1331.8e7a4869076662c8bb756c563db5831fea87a23c.0