Added a limit to the amount of events that can be stored in the timel…

…ine tBLE_ATT_ERR_INVALID_ATTR_VALUE_LENo avoid resource exhaustion
InfiniTimeOrg · Oct 5, 2023 · 04c9b1f · 04c9b1f
1 parent 46b664b
commit 04c9b1f
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/components/ble/weather/WeatherService.cpp b/src/components/ble/weather/WeatherService.cpp
@@ -74,6 +74,11 @@ namespace Pinetime {
           return BLE_ATT_ERR_INVALID_ATTR_VALUE_LEN;
         }
 
+        // Enforce a reasonable limit to the amount of RAM that can be used
+        if (GetTimelineLength() > WeatherData::eventtype::Length) {
+            return BLE_ATT_ERR_INVALID_ATTR_VALUE_LEN;
+        }
+
         switch (static_cast<WeatherData::eventtype>(tmpEventType)) {
           case WeatherData::eventtype::AirQuality: {
             std::unique_ptr<WeatherData::AirQuality> airquality = std::make_unique<WeatherData::AirQuality>();