weather: Add new app with forecast

[vkareh]

Added a new weather app that shows the current weather and forecast. If forecast is not available, it just shows the current weather.

Building the sim requires InfiniTimeOrg/InfiniSim#138

[github-actions]

Build size and comparison to main:

Section	Size	Difference
text	377080B	3840B
data	940B	0B
bss	63516B	0B

[FintasticMan]

Looks good! Is there enough space to add the ° symbol to the forecast? It looks a bit off without it IMO. It might also be nice to know the current min and max temp?

About the forecast not showing up with Breezy Weather + Gadgetbridge, could you check if it works with Tiny Weather Forecast Germany? The Gadgetbridge side should be working, so I suspect that Breezy Weather just doesn't provide that information.

[FintasticMan]

One small thing, for the rest this looks good!

[vkareh]

Ha! Found the issue. The wrong variable was being referenced in Gadgetbridge and so was not sending forecast data. I've submitted a patch to fix it: https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/3551

@FintasticMan Thanks for reviewing, I'll start addressing these issues sometime today.

[FintasticMan]

Oh oopsie, that was my code in GB 😅

Thanks for finding and submitting a fix.

[vkareh]

@FintasticMan

Looks good! Is there enough space to add the ° symbol to the forecast? It looks a bit off without it IMO.

Unfortunately no. With the ° symbol things start wrapping when you get to double-digit negative temperatures. This is also already the smallest font available.

It might also be nice to know the current min and max temp?

Added that now. Also added the location. Maybe it's too busy?

I also made the temperature yellow so that it stands out a bit more from the rest.

Thoughts?

[FintasticMan]

I think that looks good, but I'm not exactly the best at UI design. If some more people chime in, I think that this is good! (You do still need to fix some formatting FYI. You can use the git pre-commit hook to do this automatically.)

[vkareh]

@FintasticMan thanks - formatting is fixed now. The sim build breaks due to a new operator override in the Forecast struct. Should be fixed by InfiniTimeOrg/InfiniSim#138

[vkareh]

I removed the location display. It was causing my watch to crash and reboot. I might debug it later, but easier to remove it for now...

[FintasticMan]

Do positive numbers above 100 display fine? That is possible with Fahrenheit I think...

[vkareh]

Yep, they look fine. The problem would be if it gets to 100 below zero (e.g. -100 has 4 characters), but we have far bigger problems if that's the case 😆

Acceptable display range would then be -99 to 999, from a purely technical point of view.

[minacode]

This looks very good! I am looking forward to use this app once the support in InfiniLink is ready.

One small thing: you could use InfiniTimes theme colors.

[vkareh]

@minacode

One small thing: you could use InfiniTimes theme colors.

I'd be more than happy to take suggestions on how to improve the thing. Here are two options using the InfiniTimeTheme colors:

Any preference? Other color combinations? I haven't been able to figure out how to change the color of the text in the forecast table...

[KaffeinatedKat]

that looks incredible, great work. Would it be possible to have the color change based on the temp? (eg. blue for cold and yellow/red for hot). That would really help bring it together imo

[JustScott]

Wow this looks great! Do you think it would be possible to fit the date and/or week day above or below each forecast. Example: 'thu', 'fri', '2/1', '2/17'?

[vkareh]

that looks incredible, great work. Would it be possible to have the color change based on the temp? (eg. blue for cold and yellow/red for hot). That would really help bring it together imo

Thanks! I love this idea.

Wow this looks great! Do you think it would be possible to fit the date and/or week day above or below each forecast. Example: 'thu', 'fri', '2/1', '2/17'?

I'll try, but I suspect there won't be much room for this. Also, this app is already annoyingly heavy (3388B as of last build), and calculating the days based on timestamps and then displaying that on a table will eat up a lot more, I think.

[vkareh]

What are your thoughts on this? Anything 0°C or below is blue, 40°C or above is red, anything else is yellowish:

[JustScott]

Wow this looks great! Do you think it would be possible to fit the date and/or week day above or below each forecast. Example: 'thu', 'fri', '2/1', '2/17'?

I'll try, but I suspect there won't be much room for this. Also, this app is already annoyingly heavy (3388B as of last build), and calculating the days based on timestamps and then displaying that on a table will eat up a lot more, I think.

Perhaps just adding the weekday and date for today somewhere could work, like is done on the digital watch face where it's a less visible grey.

[minacode]

Maybe increase the space between the big temperature and the description above?

[vkareh]

How about now?

I tried putting the current day/time (last updated time, really) but it was hard to align everything. It was just too cluttered...

[KaffeinatedKat]

that looks really awesome, we don't really need to show the current day/time because that's easily accessible elsewhere. Having the forecasted days shown is more important. Great work

[MoonlightWave-12]

What are your thoughts on this? Anything 0°C or below is blue, 40°C or above is red, anything else is yellowish:

I think blue for ~10°C and lower, and red for ~30°C and higher would be more useful.

Personally, i would prefer it to be separated somewhat like this:

• <= 4°C: blue – water can freeze at those temperatures
• 5-15°C: bright blue – a cool temperature-range
• 15-22°C: white – medium-range
• 22-28°C: yellow – like a warm spring or mild summer
• >= 29°C: red – hot

---

2 more suggestions:

• Assuming the top forecast-values are minimum and the bottom ones maximum:
  The maximum should be at the top, because it is higher.

• Maybe also colour the forecast-values, so that one can see the temperature-ranges easily at a glance?

[vkareh]

@MoonlightWave-12

The maximum should be at the top, because it is higher.

Good idea. Done:

With regards to temperature colors, anything between 0°C and 40°C starts to become really subjective. Where I live currently 5°C is a very warm winter day, whereas 30°C is a hot summer day. However, I grew up in a place where 90°F is a mild winter day.

I'm okay with your ranges, but would like some consensus before comitting to those numbers. I also propose these:

• 0 or lower: blue (freezing)
• 0 - 4: cyan (ice warning)
• 4 - 32: yellow (nothing special, but color white doesn't look great here)
• 32 or higher: red (hot)

The 32°C number is from wikipedia but we can also use 27°C

[vkareh]

@MoonlightWave-12

Maybe also colour the forecast-values, so that one can see the temperature-ranges easily at a glance?

That'd be nice, but I haven't figured out how to apply color to the table cells, only the table border (which I made black to blend in with the background)

[minacode]

We could center the cells and pad them with spaces if necessary.

[FintasticMan]

Good thinking!

[vkareh]

Sounds like a good idea. I can try, but each cell will need to know how many digits are in the temperature above or below itself and then add padding based on that. Maybe just centering all of them is not that bad after all?

Anyway, I'll see what I can pull off next time I'm playing with this.

[vkareh]

@FintasticMan @minacode - success! I managed to use character padding to align temperatures:

• With table borders (to visualize the alignment):
  
• Without table borders:
  
• With more realistic data:
  

[JF002]

I'm very happy to see this new app since the protocol allows for forecast data, but we had no way of displaying those info so far!

This feature looks good overall and I guess we'll be able to merge it as soon as the remaining code change requests and review are addressed :)

[JF002]

This calculation is done multiple times (and it's not easy to understand what it does - rounding?). Consider moving it to a dedicated function. The name of this function will also help understanding the meaning of it.

[FintasticMan]

Yes, this is so that it gets rounded properly. I added it to the PTS watch face, but maybe we should add a function to SimpleWeatherService that does this calculation.

[FintasticMan]

I've just created that function in #2015.

[vkareh]

I added this function directly in the weather app to avoid having to push a new change to InfiniSim, but let me know if we should change this.

[FintasticMan]

I think it would be better to have the function in the weather service tbh, but it doesn't matter so much.

[JF002]

LGTM! Thanks for your work @vkareh !

I've just tested it with Tiny Weather Forecast Germany and Gadgetbridge :

Reminder : the current version of Gadgetbridge (0.78) has a bug that prevents forecast from being sent to the watch (https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/3551). The fix is merged, so I guess it'll be available in 0.79 (which is already tagged but not available in f-droid).

[tituscmd]

Out of curiosity:
Are the weekdays on the bottom displaying the next week, or is it the current week?
If it is the current week, I think it would be a good idea to color the current day - maybe red?