Improved the Terminal Watchfaces UI #2135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
+ Reorder code to match the widgets order in the UI. + Use InfintimeTheme Colors instead of hardcoded hex values + Added a new InfinitimeTheme color: gray, using it to turn certain values gray when they contain no data + Implement @vkareh's [variable battery icon](InfiniTimeOrg#1964) color to the battery percentage text. + Replaced the 'You have mail.' notification message with the message '[1]+ Notify' to better fit the terminal lore.
JustScott
force-pushed
the
improve_terminal_watchface_ui
branch
from
c312a6c to
d2382e1
Compare
mark9064
reviewed
Oct 5, 2024
| // between red and green, thus avoiding the darker RGB on medium battery | ||
| // charges and giving us a much nicer color range. | ||
| uint8_t hue = batteryPercentRemaining.Get() * 120 / 100; | ||
| lv_obj_set_style_local_text_color(batteryValue, LV_LABEL_PART_MAIN, LV_STATE_DEFAULT, lv_color_hsv_to_rgb(hue, 100, 100)); |
There was a problem hiding this comment.
I think colours here are nice, but this shows yellow at 50% right? I think it would make more sense to follow a curve closer to the current battery icon (yellow at 15, red at 5). Not sure what function would represent this well but coming up with something in Desmos/similar would be easy
Also if this is to be used in other places as well, it should probably be moved out so other screens can use it. I don't know if that's the goal here though
There was a problem hiding this comment.
I see this is from #1964 , so I think it definitely makes sense to move the colour calculation algorithm to somewhere where other apps can use it
| heartbeat = heartRateController.HeartRate(); | ||
| heartbeatRunning = heartRateController.State() != Controllers::HeartRateController::States::Stopped; | ||
| if (heartbeat.IsUpdated() || heartbeatRunning.IsUpdated()) { | ||
| if (heartbeatRunning.Get()) { | ||
| lv_label_set_text_fmt(heartbeatValue, "[L_HR]#ee3311 %d bpm#", heartbeat.Get()); | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were originally proposed in PR #2001 along with the addition of weather data on it's own line, but it was suggested they be seperated. This PR is just the UI improvements without the weather, and #2001 will add the weather.
Reorder code to match the widgets order in the UI.
Use InfintimeTheme Colors instead of hardcoded hex values
Added a new InfinitimeTheme color: gray, using it to turn certain values gray when they contain no data
Implement @vkareh's variable battery icon color to the battery percentage text.
Replaced the 'You have mail.' notification message with the message '[1]+ Notify' to better fit the terminal lore.