Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weather to the terminal watch face #2204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JustScott
Copy link
Contributor

This was originally part of #2001 but is being split into its own PR without the non-weather changes to give it the ability to be merged without those changes.

This PR adds the current temperature and condition to the terminal watch face with dynamic coloring. In it's current state many of the conditions will overflow off the right side of the screen, but this will be fixed in #2134 which has already been added to the 1.16.0 milestone.

InfiniSim_2024-12-20_215457
InfiniSim_2024-12-20_215500
InfiniSim_2024-12-20_215515
InfiniSim_2024-12-20_221501

Copy link

Build size and comparison to main:

Section Size Difference
text 373280B 464B
data 948B 0B
bss 22536B 0B

@mark9064 mark9064 added the enhancement Enhancement to an existing app/feature label Dec 21, 2024
@mark9064
Copy link
Member

Looks good! Thanks for splitting this out, definitely easier to review now - I get that more branches is more work for you

So currently there are 4 "bands", as the weather app uses an LVGL table which requires a "style" for every colour used (from what I can see, maybe there are some workarounds). Would it makes sense to use a continuous colour scale (maybe somewhat like #1964) in this scenario? It might be better to stick to the colour bands for consistency, I'm not sure. Either way I think is might be a good opportunity to pull out temperature->colour conversion into the temperature class (support both bands and continuous or just bands), as it's probably not a good idea to duplicate colour conversion code across the codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing app/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants