Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Realm crash on invalidated object in File action sheet #1467

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

fix: Realm crash on invalidated object in File action sheet #1467

wants to merge 21 commits into from
+209 −186

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Mar 6, 2025 •
edited
Loading

  • Reworked FileActionsFloatingPanelViewController to function with frozen objects instead of live ones internally.
    • Reworked setFile() function to work consistently given any realm object in any state.
      • Previously, given an entry point, the behaviour could be dissimilar.
  • Fix an issue with an invalidated live object, since it works with frozen objects internally now.
  • In production, it is relatively easy to glitch the "available offline" function. This is now way more stable.

@adrien-coye adrien-coye added the bug Something isn't working label Mar 6, 2025
@adrien-coye adrien-coye force-pushed the fix/safer-FileActionsFloatingPanelViewController branch from 177c0ce to 0b87e2b Compare March 19, 2025 08:48
@adrien-coye adrien-coye changed the title fix: Realm crash on invalidated object fix: Realm crash on invalidated object in File action sheet Mar 20, 2025
adrien-coye
adrien-coye commented Mar 20, 2025
View reviewed changes
Copy link
Contributor Author

@adrien-coye adrien-coye left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a self review, also tested each available action for non regression

@adrien-coye adrien-coye force-pushed the fix/safer-FileActionsFloatingPanelViewController branch from a81738c to 2d8bdd9 Compare March 20, 2025 09:45
@adrien-coye adrien-coye marked this pull request as ready for review March 20, 2025 10:39
@adrien-coye adrien-coye added this to the 5.3.1 milestone Mar 24, 2025
@adrien-coye adrien-coye force-pushed the fix/safer-FileActionsFloatingPanelViewController branch 3 times, most recently from a02e6de to 47ae4b4 Compare March 26, 2025 10:13
@adrien-coye adrien-coye modified the milestones: 5.3.1, 5.4.0 Mar 26, 2025
@adrien-coye adrien-coye force-pushed the fix/safer-FileActionsFloatingPanelViewController branch from 47ae4b4 to 138290a Compare March 27, 2025 10:16
@adrien-coye adrien-coye marked this pull request as draft March 28, 2025 13:13
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann Awaiting requested review from PhilippeWeidmann

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@adrien-coye