In MaterializeAction replace [any] by any[] #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[any] only has 1 element in its array.
any[] can has multiple elements.
It allows things like
this.tabsActions.emit({action: "tabs", params: ['select_tab', page]}); that several persons were looking for, and it's compatible with previous version.
[any] to any[]
|
How do I use this PR? Using npm install doesn't seem to work since I don't have proper rights. Thanks. |
|
I'm more than happy to open this project for other contributors to maintain - please DM me if you're interested |
|
Hi,
If i'm not alone in this, i would be happy to contribute.
2018-05-11 7:35 GMT+02:00 rubyboy <[email protected]>:
… I'm more than happy to open this project for other contributors to
maintain - please DM me if you're interested
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#411 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABN9mzOb72rcXGRh2LdGVwu2aCPEE0ugks5txSMNgaJpZM4SFTbS>
.
|
|
@rubyboy Thanks...I'm not looking to contribute. It looks like @Dakayl has already created a PR for what I need. I'm new to using other developers' github repos and want to know how to install or build this particular PR for angular2-materialize node package with this change (changing [any] to any[] for MaterialActions). |
|
Does this mean that we can now emit all the other functions different elements like
Edit: Sorry, These functions are only available in Materialize 1.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing parameters type in MaterializeAction
From [any] to any[].
[any] only has 1 element in its array.
any[] can has multiple elements.
These are not equivalent.
Changing to any[] allows things like
this.tabsActions.emit({action: "tabs", params: ['select_tab', page]}); that several persons were looking for, and it's compatible with previous versions.