Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no redirect on save #599

Closed
wants to merge 4 commits into from
Closed

fix: no redirect on save #599

wants to merge 4 commits into from

Conversation

pooriamehregan
Copy link
Contributor

fixes #585

@pooriamehregan pooriamehregan requested a review from a team October 13, 2023 10:34
Copy link
Contributor

@jeffreiffers jeffreiffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det holder ikke å bare ikke gjøre en redirect her. Du må også sørge for at formen har riktig status med tanke på initial lastet begrep.

@@ -196,6 +196,12 @@ export const FormConceptPure: FC<Props> = ({
return () => {};
}, [dirty, showUserPrompt, saveCalled, deleteCalled]);

useEffect(() => {
if (saveCalled) {
window.location.reload();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hva skjer hvis du nå lagrer et helt nytt begrep?

Copy link
Contributor Author

@pooriamehregan pooriamehregan Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tror lagringsfunksjonaliteten vil fungere som før, men i stedet for å bli redirectet til begrepskatalogen etter lagring, så refreshes siden på nytt for å hente sise oppdateringene som ble lagret etter click på lagre-knappen.

Copy link
Contributor

@NilsOveTen NilsOveTen Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

joa, men vil den da ikke tro at du vil opprette enda et nytt begrep?
siden du ikke har id i uri-feltet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Har testet nå. Den lander på samme uri hver gang. Men kan hende jeg misforstår deg

@jeffreiffers
Copy link
Contributor

Denne kan lukkes!

@hegeaal hegeaal closed this Oct 24, 2023
@hegeaal hegeaal deleted the fix/por/no-redirect branch October 24, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: lagring redirecter bruker til feil side
4 participants