Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reapply revert #401

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

reapply revert #401

wants to merge 2 commits into from

Conversation

NilsOveTen
Copy link
Contributor

@NilsOveTen NilsOveTen commented Dec 2, 2024

ser ut til å fungere ok så lenge denne er merga først: Informasjonsforvaltning/concept-catalog-gui#670

resolve #396

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 83.92857% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.06%. Comparing base (5c4be9e) to head (d87da7c).

Files with missing lines Patch % Lines
...n/no/fdk/concept_catalog/elastic/ElasticUpdater.kt 0.00% 8 Missing ⚠️
...n/no/fdk/concept_catalog/service/ConceptService.kt 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #401      +/-   ##
============================================
- Coverage     84.35%   84.06%   -0.30%     
+ Complexity      477      471       -6     
============================================
  Files            52       52              
  Lines          1771     1770       -1     
  Branches        279      277       -2     
============================================
- Hits           1494     1488       -6     
- Misses          123      129       +6     
+ Partials        154      153       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NilsOveTen NilsOveTen marked this pull request as draft December 9, 2024 14:14
@jeffreiffers
Copy link
Contributor

Skal du ha review på denne?

@NilsOveTen
Copy link
Contributor Author

NilsOveTen commented Jan 7, 2025

Skal du ha review på denne?

Kanskje senere, dette ble satt på vent til du har fått prodsatt nye skjemaet

fjerna dere fra review enn så lenge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

published-filter skal også få treff om det finnes tidligere versjoner som har blitt publisert
2 participants