feat: try to improve first org creation perf #855
pre-merge-tests.yml
on: pull_request
Matrix: Run Tests
analyze-code
5m 28s
Notify Slack of Success
4s
Notify Slack of Failure
0s
Annotations
76 warnings
Build Angular site
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-node@v3, actions/setup-dotnet@v3, actions/setup-python@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Build Vue Site
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-node@v3, actions/setup-dotnet@v3, actions/setup-python@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Build Vue Site:
src/OrganisationRegistry.Vue2/src/alerts/alerts.js#L77
Unexpected console statement
|
Build Vue Site:
src/OrganisationRegistry.Vue2/src/api/importOrganisations.js#L49
Unexpected console statement
|
Build Vue Site:
src/OrganisationRegistry.Vue2/src/api/importOrganisations.js#L77
Unexpected console statement
|
Build Vue Site:
src/OrganisationRegistry.Vue2/src/api/importOrganisations.js#L99
Unexpected console statement
|
Build Vue Site:
src/OrganisationRegistry.Vue2/src/api/oidc.js#L45
Unexpected console statement
|
Build Vue Site:
src/OrganisationRegistry.Vue2/src/api/oidc.js#L46
Unexpected console statement
|
Build Vue Site:
src/OrganisationRegistry.Vue2/src/api/oidc.js#L62
Unexpected console statement
|
Build Vue Site:
src/OrganisationRegistry.Vue2/src/api/oidc.js#L63
Unexpected console statement
|
Build Vue Site:
src/OrganisationRegistry.Vue2/src/api/security.js#L15
Unexpected console statement
|
Build Vue Site:
src/OrganisationRegistry.Vue2/src/api/security.js#L34
Unexpected console statement
|
Run Tests (test/OrganisationRegistry.UnitTests)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Run Tests (test/OrganisationRegistry.UnitTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.UnitTests)
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.UnitTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.UnitTests):
test/OrganisationRegistry.ElasticSearch.Tests/OrganisationHandlerTests.cs#L483
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.UnitTests)
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.UnitTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.UnitTests)
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.UnitTests):
test/OrganisationRegistry.SqlServer.IntegrationTests/OnProjections/Person/PersonFunctionsListViewTests.cs#L50
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests):
test/OrganisationRegistry.ElasticSearch.Tests/OrganisationHandlerTests.cs#L483
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests)
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.KboMutations.UnitTests):
test/OrganisationRegistry.SqlServer.IntegrationTests/OnProjections/Person/PersonFunctionsListViewTests.cs#L50
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests):
test/OrganisationRegistry.SqlServer.IntegrationTests/OnProjections/Person/PersonFunctionsListViewTests.cs#L50
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests)
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests):
test/OrganisationRegistry.SqlServer.IntegrationTests/OnProjections/Person/PersonFunctionsListViewTests.cs#L50
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.SqlServer.IntegrationTests):
test/OrganisationRegistry.SqlServer.IntegrationTests/OnProjections/Person/PersonFunctionsListViewTests.cs#L50
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests):
test/OrganisationRegistry.ElasticSearch.Tests/OrganisationHandlerTests.cs#L483
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests):
test/OrganisationRegistry.ElasticSearch.Tests/OrganisationHandlerTests.cs#L483
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests)
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.ElasticSearch.Tests):
test/OrganisationRegistry.SqlServer.IntegrationTests/OnProjections/Person/PersonFunctionsListViewTests.cs#L50
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.Api.IntegrationTests):
test/OrganisationRegistry.ElasticSearch.Tests/OrganisationHandlerTests.cs#L483
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Run Tests (test/OrganisationRegistry.Api.IntegrationTests)
Dereference of a possibly null reference.
|
Run Tests (test/OrganisationRegistry.Api.IntegrationTests):
test/OrganisationRegistry.SqlServer.IntegrationTests/OnProjections/Person/PersonFunctionsListViewTests.cs#L50
'OrganisationTerminated.OrganisationTerminated(Guid, string, string, DateTime, FieldsToTerminate, KboFieldsToTerminate, bool, DateTime?)' is obsolete: 'Use OrganisationTerminatedV2 instead.'
|
Notify Slack of Success
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: slackapi/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Notify Slack of Success
The following actions uses node12 which is deprecated and will be forced to run on node16: slackapi/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Notify Slack of Success
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Notify Slack of Success
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Notify Slack of Success
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
analyze-code
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-dotnet@v3, actions/setup-java@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
analyze-code
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-java@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
analyze-code:
src/OrganisationRegistry.Magda/MagdaModule.cs#L54
Constructor has 8 parameters, which is greater than the 7 authorized.
|
analyze-code:
src/OrganisationRegistry.OpenTelemetry/Extensions/ServiceCollectionExtensions.cs#L135
Remove this commented out code.
|
analyze-code:
src/OrganisationRegistry.OpenTelemetry/OpenTelemetryMetrics.cs#L24
Remove this commented out code.
|
analyze-code:
src/OrganisationRegistry.OpenTelemetry/OpenTelemetryMetrics.cs#L62
Remove this commented out code.
|
analyze-code:
src/OrganisationRegistry.OpenTelemetry/OpenTelemetryMetrics.cs#L10
Remove the field '_meter' and declare it as a local variable in the relevant methods.
|
analyze-code:
src/OrganisationRegistry.OpenTelemetry/OpenTelemetryMetrics.cs#L9
Make this field 'private' and encapsulate it in a 'public' property.
|
analyze-code:
src/OrganisationRegistry.OpenTelemetry/OpenTelemetryMetrics.cs#L9
Change the visibility of 'MeterNameFunc' or make it 'const' or 'readonly'.
|
analyze-code:
src/OrganisationRegistry.OpenTelemetry/OpenTelemetryMetrics.cs#L32
Change the visibility of 'EnvelopesHandled' or make it 'const' or 'readonly'.
|
analyze-code:
src/OrganisationRegistry.OpenTelemetry/OpenTelemetryMetrics.cs#L33
Change the visibility of 'EnvelopesBehind' or make it 'const' or 'readonly'.
|
analyze-code:
src/OrganisationRegistry.OpenTelemetry/OpenTelemetryMetrics.cs#L34
Change the visibility of 'LastProcessedEvent' or make it 'const' or 'readonly'.
|