Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish: Add first translation, Introduction to the Learning Path #351

Merged

Conversation

dicortazar
Copy link
Member

No description provided.

@dicortazar dicortazar requested a review from a team as a code owner November 25, 2020 18:04
@dicortazar
Copy link
Member Author

This is a work in progress with the goal of checking if this is the right approach and if you any advise.

Thanks!

@dicortazar dicortazar marked this pull request as draft November 25, 2020 18:12
@lenucksi lenucksi changed the title Add first translation, Introduction to the Learning Path Spanish: Add first translation, Introduction to the Learning Path Nov 25, 2020
@lenucksi lenucksi added Introduction "Introduction" Segments of the Learning Path Translation If you'd like to translate our material to you language. Translations are very welcome! :D labels Nov 25, 2020
@lenucksi
Copy link
Member

lenucksi commented Nov 25, 2020

This is a work in progress with the goal of checking if this is the right approach and if you any advise.

Thanks!

Looks good so far as I'm concerned. @tsadler1988 might want to advise on anything we need to look after for our rendering things.
Also, consider adding a bunch of translation strings to #333

We'll also need some independent Spanish speaking reviewers for the content. Since my Spanish is lousy I'm happy to merge once I see a LGTM but can't do any reviewing myself.

@lenucksi lenucksi requested a review from tsadler1988 November 25, 2020 19:41
@rrrutledge
Copy link
Contributor

Awesome, Daniel! I myself speak fluent Spanish and so could review, but we'd prefer a native speaker. Do you know of one in the InnerSource Commons community? Ideally a non-Bitergian.

@tsadler1988
Copy link
Collaborator

Thanks for this @dicortazar!

Regarding rendering on the website, you will need to add es to the Introduction translations config as per the instructions for updating innersourcecommons.org with new articles, but this isn't mandatory and could be done separately.

@rrrutledge rrrutledge linked an issue Dec 3, 2020 that may be closed by this pull request
6 tasks
@dicortazar dicortazar marked this pull request as ready for review January 8, 2021 12:47
Copy link
Contributor

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!Gracias por este trabajo!

Un ejemplo podría ser una aplicación final de usuario que depende de una API que recoge datos que después son visualizados. Esta situación es en realidad relativamente común dentro de las grandes corporaciones, donde un solo equipo produce un software que puede tener docenas o centenares de usuarios finales.

Cuando esos consumidores finales necesitan añadir funcionalidades, los equipos que desarrollan generalmente tienen procesos internos donde priorizan y gestionan los requisitos y así deciden en qué funcionalidades trabajarán.
En el caso de funcionalidades críticas para los equipos que consumen ese software hay generalmente tres opciones, aunque cada una tiene sus propios problemas.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add something about the fact that these critical feature requests are not prioritized?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right that the very last sentence is not exactly the same as the one in English. I'll reword this a bit :).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the new version

Este trabajo extra puede que traiga cambios en el equipo que usa el software.
Alternativamente, el equipo consumidor puede crear un nuevo proyecto que se adecúe a sus necesidades y reemplace el uso de la herramienta original en parte o totalmente (duplicación de código/proyecto y esfuerzos).
Esta estrategia permite que el equipo que consume el software obtenga su nueva funcionalidad deseada a través de sus propios esfuerzos, aunque esto venga con ciertos inconvenientes.
..Cualquier tipo de trabajo que realice el equipo que consume el software no va a poder ser reutilizado por otros equipos que necesiten la misma funcionalidad.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be ASCIIDOC-formatted as a list?

Suggested change
..Cualquier tipo de trabajo que realice el equipo que consume el software no va a poder ser reutilizado por otros equipos que necesiten la misma funcionalidad.
* Cualquier tipo de trabajo que realice el equipo que consume el software no va a poder ser reutilizado por otros equipos que necesiten la misma funcionalidad.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I copied this from the original document format.

Should I use stars as you suggest?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right! Something's wrong, though. It doesn't render as a list.

Screen Shot 2021-02-19 at 6 13 40 AM

Comparing again to the English version, perhaps you need a space between the dots and the text?

Suggested change
..Cualquier tipo de trabajo que realice el equipo que consume el software no va a poder ser reutilizado por otros equipos que necesiten la misma funcionalidad.
.. Cualquier tipo de trabajo que realice el equipo que consume el software no va a poder ser reutilizado por otros equipos que necesiten la misma funcionalidad.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :)

introduction/es/02-problems-solved-es.asciidoc Outdated Show resolved Hide resolved
Signed-off-by: Daniel Izquierdo Cortazar <[email protected]>
Copy link
Contributor

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! Just one thing I noticed.

Este trabajo extra puede que traiga cambios en el equipo que usa el software.
Alternativamente, el equipo consumidor puede crear un nuevo proyecto que se adecúe a sus necesidades y reemplace el uso de la herramienta original en parte o totalmente (duplicación de código/proyecto y esfuerzos).
Esta estrategia permite que el equipo que consume el software obtenga su nueva funcionalidad deseada a través de sus propios esfuerzos, aunque esto venga con ciertos inconvenientes.
..Cualquier tipo de trabajo que realice el equipo que consume el software no va a poder ser reutilizado por otros equipos que necesiten la misma funcionalidad.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right! Something's wrong, though. It doesn't render as a list.

Screen Shot 2021-02-19 at 6 13 40 AM

Comparing again to the English version, perhaps you need a space between the dots and the text?

Suggested change
..Cualquier tipo de trabajo que realice el equipo que consume el software no va a poder ser reutilizado por otros equipos que necesiten la misma funcionalidad.
.. Cualquier tipo de trabajo que realice el equipo que consume el software no va a poder ser reutilizado por otros equipos que necesiten la misma funcionalidad.

Signed-off-by: Daniel Izquierdo Cortazar <[email protected]>
@dicortazar
Copy link
Member Author

I think we have covered all the suggestions @rrrutledge :). Thanks for all of your comments and pointers.

@rrrutledge
Copy link
Contributor

Looking good! I will try to get this merged and deployed before our Thursday meeting.

@rrrutledge rrrutledge merged commit 72c0901 into InnerSourceCommons:master Feb 25, 2021
@dicortazar dicortazar linked an issue Apr 15, 2021 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Article Introduction "Introduction" Segments of the Learning Path Translation If you'd like to translate our material to you language. Translations are very welcome! :D
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate "Introduction" articles to Spanish Translate "Introduction" articles to Spanish
4 participants