Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing vale setup #597

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Fixing vale setup #597

merged 3 commits into from
Jan 29, 2025

Conversation

spier
Copy link
Member

@spier spier commented Jan 29, 2025

We noticed over at InnerSourceCommons/managing-innersource-projects#91 that the vale setup with custom vocabulary files did not work anymore.

The issue was related to a change in the required folder structure for custom vocabulary files. See docs.

Specifics:

In versions of Vale prior to 3.0, vocabularies were stored in <StylesPath>/Vocab.
When upgrading from an older version of Vale, you'll need to move your vocabularies to the new <StylesPath>/config/vocabularies location.

While fixing this, I also made the GH actions that we use in our workflow more stable.

@spier spier marked this pull request as ready for review January 29, 2025 22:03
@spier spier requested a review from a team as a code owner January 29, 2025 22:03
Copy link
Contributor

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rrrutledge rrrutledge merged commit b56279d into main Jan 29, 2025
1 check passed
@rrrutledge rrrutledge deleted the fixing-vale branch January 29, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants