This repository has been archived by the owner on Mar 20, 2021. It is now read-only.
Host translated learning path articles on innersourcecommons.org #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rrrutledge
commented
Sep 10, 2020
rrrutledge
commented
- Adjust learning path layout to account for translated articles
- Adding auto-generated files for translated articles
* Adjust learning path layout to account for translated articles * Adding auto-generated files for translated articles
This was referenced Sep 10, 2020
rrrutledge
commented
Sep 13, 2020
resources/learningpath/index.md
Outdated
|
|
||
| <img src="/assets/img/LP_thumbnail_introduction.jpg" alt="Learning Path Introduction Thumbnail" width="200"/> | ||
|
|
||
| Check out the Introduction to learn about the types of problems where InnerSource can help, how to do it, the types of benefits you can expect to see by participating, and the underlying principles that make it all work. | ||
|
|
||
| View in [English][Introduction], [German][German Introduction], [Japanese][Japanese Introduction], or [Chinese][Chinese Introduction] |
There was a problem hiding this comment.
@lenucksi what word shall we use to represent German? Deutsche?
There was a problem hiding this comment.
You were 99% on spot, it should be Deutsch and mostly Deutsche are going to read it. 😉
tsadler1988
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Great work Russ!
I think this is good to merge as is, but some ideas for further improvements:
- Translate 'Back to Learning Path homepage', 'Next', and 'Previous'
- Would linking to the English workbooks be better than nothing?
- Would embedding the English video be better than nothing?
Awesome! Thanks for this review. Can you open and issue or otherwise bring this up in the #learning-path. |
Late, but done! |
|
Thanks, Tom! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.